feat: add rpc query for viewing global contract code #13547
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #13547 +/- ##
===========================================
+ Coverage 1.62% 69.49% +67.86%
===========================================
Files 660 855 +195
Lines 114960 167998 +53038
Branches 114960 167998 +53038
===========================================
+ Hits 1873 116747 +114874
+ Misses 113031 46481 -66550
- Partials 56 4770 +4714
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
5dfe82a to
47978a7
Compare
|
hey, sorry, I'm OOO tomorrow and I won't be able to review it today, if you need a fast review please ask someone else, otherwise I'll have a look next week. |
| #[error( | ||
| "Global contract code with identifier {identifier:?} has never been observed on the node" | ||
| )] | ||
| NoGlobalContractCode { | ||
| identifier: near_primitives::action::GlobalContractIdentifier, | ||
| block_height: near_primitives::types::BlockHeight, | ||
| block_hash: near_primitives::hash::CryptoHash, | ||
| }, |
There was a problem hiding this comment.
This is duplicated, does it need to be?
There was a problem hiding this comment.
unfortunately yes, I was also annoyed by this
| | QueryRequest::ViewGlobalContractCodeByAccountId { .. } => { | ||
| // for global contract queries we can use any shard_id, so just take the first one | ||
| let shard_ids = self.epoch_manager.shard_ids(&epoch_id)?; | ||
| Ok(*shard_ids.iter().next().expect("at least one shard should always exist")) |
There was a problem hiding this comment.
cc @staffik Just musing - this will be fun when we move to single shard tracking RPC
6910ea6 to
f13a8a5
Compare
This PR adds
QueryRequestfor retrieving global contract code. This is needed becauseViewCodequery only allows retrieving contracted used as part of the specified accounts. Global contracts deployed separately, so we need to have a dedicated view query.2 separate enum variants are introduced for queries by hash (
ViewGlobalContractCode) and by account id (ViewGlobalContractCodeByAccountId) to have simple API and keep it consistent withDeployGlobalContract/UseGlobalContractactions.QueryResponseKind::ViewCodeis reused for the response.Also
QueryError::NoGlobalContractCodeerror is introduced, similar toNoContractCode.Closes #13531.