Skip to content

Conversation

jakmeier
Copy link
Contributor

@jakmeier jakmeier commented Jan 3, 2023

Fixes a problem for daily estimations, introduced in #8251.

Because account IDs were not constant, the TX sizes
depended on the randomly picked indices, which caused
some failures in daily estimations where more accounts
were used than in local testing.

Because account IDs were not constant, the TX sizes
depended on the randomly picked indices, which caused
some failures in daily estimations where more accounts
were used than in local testing.
@jakmeier jakmeier requested a review from nagisa January 3, 2023 15:37
@jakmeier jakmeier requested a review from a team as a code owner January 3, 2023 15:37
@jakmeier
Copy link
Contributor Author

jakmeier commented Jan 5, 2023

@nagisa can you review this please? I think you've also reviewed the estimation code which this affects.

@nagisa
Copy link
Collaborator

nagisa commented Jan 5, 2023

Sorry, I had this open, reviewed halfway through and then got distracted by my own code :/

@near-bulldozer near-bulldozer bot merged commit 009b1cb into near:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants