Skip to content

hotfix: non-contract-usage feature flag #1370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 1, 2025
Merged

hotfix: non-contract-usage feature flag #1370

merged 3 commits into from
Jul 1, 2025

Conversation

frolvanya
Copy link
Contributor

@frolvanya frolvanya commented Jul 1, 2025 •
edited
Loading

This change was discussed with @frol. Basically, sometimes near-sdk is needed in non-contract environment. Right now the only workaround is to use unit-testing feature flag, but this flag has extra dependencies on near crates, so it's better to introduce a new flag

@frolvanya frolvanya requested a review from frol July 1, 2025 18:27
@github-project-automation github-project-automation bot moved this to NEW❗ in DevTools Jul 1, 2025
frol
frol approved these changes Jul 1, 2025
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 2

@race-of-sloths
Copy link

race-of-sloths commented Jul 1, 2025 •
edited
Loading

@frolvanya Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Do you want to apply for monthly streak? Get 8+ score for a single PR this month and receive boost for race-of-sloths!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 2

Your contribution is much appreciated with a final score of 2!
You have received 21 (20 base + 5% lifetime bonus) Sloth points for this contribution

@frol received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol frol changed the title chore: non-contract-usage feature flag hotfix: non-contract-usage feature flag Jul 1, 2025
@frol frol enabled auto-merge (squash) July 1, 2025 18:47
@codecov Codecov
Copy link

codecov bot commented Jul 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.25%. Comparing base (43ecba8) to head (21b6798).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1370      +/-   ##
==========================================
+ Coverage   80.15%   80.25%   +0.09%     
==========================================
  Files         104      104              
  Lines       15272    15272              
==========================================
+ Hits        12241    12256      +15     
+ Misses       3031     3016      -15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@frol frol merged commit 49ffc88 into master Jul 1, 2025
41 checks passed
@frol frol deleted the chore/non-contract-usage-feature branch July 1, 2025 19:02
@github-project-automation github-project-automation bot moved this from NEW❗ to Shipped 🚀 in DevTools Jul 1, 2025
@frol frol mentioned this pull request Jul 1, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@dj8yfo dj8yfo Awaiting requested review from dj8yfo

@ruseinov ruseinov Awaiting requested review from ruseinov

@akorchyn akorchyn Awaiting requested review from akorchyn akorchyn is a code owner

@PolyProgrammist PolyProgrammist Awaiting requested review from PolyProgrammist PolyProgrammist is a code owner

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: Shipped 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frolvanya @race-of-sloths @frol