chore: update near-* dependencies to 0.31 release #1379
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1379 +/- ##
==========================================
- Coverage 80.83% 80.81% -0.03%
==========================================
Files 104 104
Lines 15443 15457 +14
==========================================
+ Hits 12483 12491 +8
- Misses 2960 2966 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| LogicMockAction::DeployGlobalContract { receipt_index, code, mode } => { | ||
| let contract_mode: GlobalContractDeployMode = match mode { | ||
| GlobalContractDeployModeVM::AccountId => GlobalContractDeployMode::AccountId, | ||
| GlobalContractDeployModeVM::CodeHash => GlobalContractDeployMode::CodeHash, | ||
| }; | ||
|
|
||
| Self::DeployGlobalContract { receipt_index, code, mode: contract_mode } | ||
| } | ||
| LogicMockAction::UseGlobalContract { receipt_index, contract_id } => { | ||
| let contract_identifier: GlobalContractIdentifier = match contract_id { | ||
| GlobalContractIdentifierVM::AccountId(account_id) => { | ||
| GlobalContractIdentifier::AccountId(account_id) | ||
| } | ||
| GlobalContractIdentifierVM::CodeHash(code_hash) => { | ||
| GlobalContractIdentifier::CodeHash(code_hash) | ||
| } | ||
| }; | ||
|
|
||
| Self::UseGlobalContract { receipt_index, contract_id: contract_identifier } | ||
| } |
There was a problem hiding this comment.
I believe there is a better way to do this, however, as GlobalContractDeployMode and GlobalContractIdentifier in near_vm_runner do not derive PartialEq and Eq, I see using previously mentioned types from near_primitives::action as one of the main solutions to this (esp, as near_primitives already included for unit-testing feature)
There was a problem hiding this comment.
Sounds good. Maybe even better comparing to exposing some near vm runner types
|
@vsavchyn-dev Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 3! @frol received 25 Sloth Points for reviewing and scoring this pull request. What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
No description provided.