Skip to content

Docs: add explanation for borsh parameters in #[near(serializers = [...])] #1359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 30, 2025
Merged

Docs: add explanation for borsh parameters in #[near(serializers = [...])] #1359

merged 7 commits into from
May 30, 2025

Conversation

Manuelshub
Copy link
Contributor

Documenation for passing parameter to the borsh serializer in conjunction with the PR #1158

@github-project-automation github-project-automation bot moved this to NEW❗ in DevTools May 25, 2025
@codecov Codecov
Copy link

codecov bot commented May 25, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.29%. Comparing base (e5ef0a5) to head (297aabd).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1359      +/-   ##
==========================================
- Coverage   80.35%   80.29%   -0.07%     
==========================================
  Files         104      104              
  Lines       15243    15243              
==========================================
- Hits        12249    12239      -10     
- Misses       2994     3004      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Manuelshub
Copy link
Contributor Author

Manuelshub commented May 25, 2025 •
edited
Loading

@frol Please review so I can make the necessary ammendments

frol
frol approved these changes May 29, 2025
View reviewed changes
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 1

@Manuelshub Thanks for the attempt, but I had to rewrite it.

@race-of-sloths
Copy link

@frol Thank you for calling!

@Manuelshub Thank you for the contribution! Join Race of Sloths by simply mentioning me in your comment/PRs description and start collecting Sloth Points through contributions to open source projects.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

@frol frol force-pushed the docs/1335-additional-param-serializers branch from 7be2e1f to e1d6b5e Compare May 29, 2025 22:40
@frol frol enabled auto-merge (squash) May 29, 2025 22:40
@frol frol disabled auto-merge May 29, 2025 22:41
@frol frol enabled auto-merge (squash) May 29, 2025 22:41
Manuelshub added 2 commits May 30, 2025 10:08
@Manuelshub
Merge branch 'master' of https://github.com/near/near-sdk-rs into doc…
17a92de 
…s/1335-additional-param-serializers
@Manuelshub
Merge branch 'docs/1335-additional-param-serializers' of github.com:M…
297aabd 
…anuelshub/near-sdk-rs into docs/1335-additional-param-serializers
@Manuelshub
Copy link
Contributor Author

@frol Thanks for the review, can I work on something else??

@frol frol merged commit 639fa9b into near:master May 30, 2025
40 of 41 checks passed
@github-project-automation github-project-automation bot moved this from NEW❗ to Shipped 🚀 in DevTools May 30, 2025
@frol frol mentioned this pull request May 30, 2025
Merged
@Manuelshub Manuelshub deleted the docs/1335-additional-param-serializers branch May 30, 2025 09:34
@Manuelshub Manuelshub restored the docs/1335-additional-param-serializers branch May 30, 2025 09:35
@Manuelshub
Copy link
Contributor Author

@frol Just to confirm, would I still get a reward on OnlyDust??

@frol
Copy link
Collaborator

frol commented May 30, 2025

Just to confirm, would I still get a reward on OnlyDust??

Nope

@frol
Copy link
Collaborator

frol commented May 30, 2025

Thanks for the review, can I work on something else??

@Manuelshub I don't have anything I can think of, but keep an eye on the issues. I am only distributing rewards for the contributions that are helping me and not forcing me making even more work.

@Manuelshub
Copy link
Contributor Author

@frol Sorry to take your time, when you say a contribution is forcing you do even more work, is my contribution is any way in that category??

@frol
Copy link
Collaborator

frol commented May 30, 2025

is my contribution is any way in that category??

This was my experience so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frol frol frol approved these changes

@dj8yfo dj8yfo Awaiting requested review from dj8yfo

@ruseinov ruseinov Awaiting requested review from ruseinov

@akorchyn akorchyn Awaiting requested review from akorchyn akorchyn is a code owner

@PolyProgrammist PolyProgrammist Awaiting requested review from PolyProgrammist PolyProgrammist is a code owner

Assignees
No one assigned
Labels
None yet
Projects
DevTools
Status: Shipped 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Manuelshub @race-of-sloths @frol