Skip to content

Conversation

ailisp
Copy link
Member

@ailisp ailisp commented Feb 7, 2023

Add benchmark, readme and tips to benchmark your use case.

@ailisp ailisp marked this pull request as ready for review February 10, 2023 05:25
@ailisp ailisp requested a review from volovyks as a code owner February 10, 2023 05:25
Copy link
Collaborator

@volovyks volovyks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall! My main concern is that it's better to store benchmark results in separate autogenerated files. It will allow us to update them with time, since gas usage will be constantly changing. But that can be done later, not a blocker now.

@@ -2,3 +2,4 @@ packages:
- "examples"
- "tests"
- "packages/*"
- "bench"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

@@ -2,3 +2,4 @@ packages:
- "examples"
- "tests"
- "packages/*"
- "bench"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Bench" gives me wrong associations. Maybe "benchmark" is better?

import { near } from "near-sdk-js";

export function empty() {
}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • lots of new empty lines at the end of files

@ailisp ailisp merged commit 343a062 into develop Feb 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants