Skip to content

Conversation

petarvujovic98
Copy link
Contributor

Use local instances of signale to scope them to commands and make them
interactive

Depends on #309

@ailisp
Copy link
Member

ailisp commented Nov 28, 2022

@petarvujovic98 Thanks! This loggin improvement is great. Do you want to merge your branch into @idea404 's , or we just merge your change and close #309 ?

@petarvujovic98
Copy link
Contributor Author

@ailisp It's all the same to me. I don't have push access so I wasn't able to push to @idea404 's #309 PR otherwise I would have just done so. We can also wait for his PR to be merged and then I will rebase and push to this PR again.

@volovyks
Copy link
Collaborator

@petarvujovic98 #309 was merged, please, update your PR and we will merge it as well. Thanks!

@volovyks
Copy link
Collaborator

Thanks for pointing out this issue @petarvujovic98 ! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants