Skip to content

private and payable functionality #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Sep 7, 2022
Merged

private and payable functionality #204

merged 12 commits into from
Sep 7, 2022

Conversation

volovyks
Copy link
Collaborator

@volovyks volovyks commented Sep 6, 2022 •
edited
Loading

  • payableFunction nad privateFunction parameters added to the @call decorator
  • both False by default
  • privateFunction is used instead of private because private is a reserved word
  • for the sake of consistency and extendability all decorators accept parameters

@volovyks volovyks changed the title @private and @payable functionality private and payable functionality Sep 6, 2022
@ailisp
Copy link
Member

ailisp commented Sep 7, 2022

The new api design on call and view looks great!

@volovyks volovyks marked this pull request as ready for review September 7, 2022 06:05
@volovyks volovyks requested a review from ailisp as a code owner September 7, 2022 06:05
@volovyks
Copy link
Collaborator Author

volovyks commented Sep 7, 2022

Thanks for the fix @ailisp!

ailisp
ailisp approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@ailisp ailisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome implementation!

@ailisp ailisp merged commit 5667584 into develop Sep 7, 2022
@ailisp ailisp deleted the serhii/private-payable branch September 7, 2022 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ailisp ailisp ailisp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@volovyks @ailisp