Skip to content

docs: updated GUIDE #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 10, 2025
Merged

docs: updated GUIDE #469

merged 5 commits into from
Apr 10, 2025

Conversation

FroVolod
Copy link
Collaborator

@FroVolod FroVolod commented Apr 7, 2025

No description provided.

@FroVolod FroVolod marked this pull request as ready for review April 7, 2025 16:35
Copy link
Collaborator

@frol frol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 8

@race-of-sloths
Copy link

race-of-sloths commented Apr 7, 2025

@FroVolod Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows inviting banner with latest news.

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@frol 8
@dj8yfo 8

Your contribution is much appreciated with a final score of 8!
You have received 84 (80 base + 5% lifetime bonus) Sloth points for this contribution

@frol received 25 Sloth Points for reviewing and scoring this pull request.
@dj8yfo received 25 Sloth Points for reviewing and scoring this pull request.

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths and receive a reward
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

docs/GUIDE.en.md Outdated
</a>
</details>

#### from-legacy-keychain - Get the public key stored in the legacy keychain (compatible with the old near CLI)
Copy link
Collaborator

@dj8yfo dj8yfo Apr 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this could provide a link to repo/pkg to disambiguate what old near CLI means

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i had most problems with this command until changing error msg on miss about which file specifically was queried.
Without full implementation details, doc can state that key is searched for in a file, whose path is computed from account-name + network + maybe smth else , according to some pattern.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/GUIDE.en.md Outdated
```txt
near account \
get-public-key \
from-ledger --seed-phrase-hd-path 'm/44'\''/397'\''/0'\''/0'\''/1'\'''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: this could use non machine-generated form with double quotes "m/44'/397'/0'/0'/1'" , which is better readable as an example

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the same nit in the spot with from-seed-phrase

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Copy link
Collaborator

@dj8yfo dj8yfo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@race-of-sloths score 8

docs/GUIDE.en.md Outdated
```txt
near account \
get-public-key \
from-ledger --seed-phrase-hd-path 'm/44'\''/397'\''/0'\''/0'\''/1'\'''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's the same nit in the spot with from-seed-phrase

docs/GUIDE.en.md Outdated
```txt
near account \
get-public-key \
from-ledger --seed-phrase-hd-path 'm/44'\''/397'\''/0'\''/0'\''/1'\'''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it can be added in doc, that only paths with precisely 5 components are supported as from-ledger paths, that is "m/44'/397'/0'/0'/10'" will work but 'm/44'\''/397'\''/0'\''' will not, unlike e.g. from-seed-phrase hd path

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/GUIDE.en.md Outdated
```txt
near account \
get-public-key \
from-ledger --seed-phrase-hd-path 'm/44'\''/397'\''/0'\''/0'\''/1'\'''
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: it can be added to doc, which category the hd paths belong too. It looks like from-ledger hd-path and from-seed-phrase hd-path share something in common, i.e. they can only start from m/44'/397' , but it's only a gut feeling, i don't have a proof for this statement

docs/GUIDE.en.md Outdated
from-ledger --seed-phrase-hd-path 'm/44'\''/397'\''/0'\''/0'\''/1'\'''
```

<details><summary><i>The result of this command will be as follows:</i></summary>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: approximately as follows

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/GUIDE.en.md Outdated
network-config testnet
```

<details><summary><i>The result of this command will be as follows:</i></summary>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: for another account will be similar to one as follows

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: doc can state, that command may block for unlocking keychain via gui-widget outside of cli input/output

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

docs/GUIDE.en.md Outdated
</a>
</details>

#### from-legacy-keychain - Get the public key stored in the legacy keychain (compatible with the old near CLI)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: i had most problems with this command until changing error msg on miss about which file specifically was queried.
Without full implementation details, doc can state that key is searched for in a file, whose path is computed from account-name + network + maybe smth else , according to some pattern.


#### download-abi - Download contract ABI

You can download the contract ABI for the current moment (***now***) and for a certain moment in the past by specifying the block (***at-block-height*** or ***at-block-hash***).
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: could add a link to https://github.com/near/abi to try to give more details about what it was, that the command was downloading

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@frol frol merged commit 642159c into main Apr 10, 2025
11 checks passed
@frol frol deleted the update-guide branch April 10, 2025 07:12
@github-project-automation github-project-automation bot moved this from NEW❗ to Shipped 🚀 in DevTools Apr 10, 2025
This was referenced Apr 10, 2025
@frol frol mentioned this pull request May 9, 2025
akorchyn pushed a commit that referenced this pull request May 14, 2025
## 🤖 New release

* `near-cli-rs`: 0.19.0 -> 0.20.0 (⚠ API breaking changes)

### ⚠ `near-cli-rs` breaking changes

```text
--- failure constructible_struct_adds_field: externally-constructible struct adds field ---

Description:
A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field.
        ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/constructible_struct_adds_field.ron

Failed in:
  field CliContract.deploy_mode in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/deploy/mod.rs:6

--- failure derive_trait_impl_removed: built-in derived trait no longer implemented ---

Description:
A public type has stopped deriving one or more traits. This can break downstream code that depends on those types implementing those traits.
        ref: https://doc.rust-lang.org/reference/attributes/derive.html#derive
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/derive_trait_impl_removed.ron

Failed in:
  type ContractFileContext no longer derives Debug, in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/deploy/mod.rs:92
  type ContractFileContext no longer derives Clone, in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/deploy/mod.rs:92

--- failure enum_missing: pub enum removed or renamed ---

Description:
A publicly-visible enum cannot be imported by its prior path. A `pub use` may have been removed, or the enum itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/enum_missing.ron

Failed in:
  enum near_cli_rs::commands::contract::deploy::ClapNamedArgContractFileForContract, previously in file /tmp/.tmporyarC/near-cli-rs/src/commands/contract/deploy/mod.rs:5

--- failure enum_no_repr_variant_discriminant_changed: enum variant had its discriminant change value ---

Description:
The enum's variant had its discriminant value change. This breaks downstream code that used its value via a numeric cast like `as isize`.
        ref: https://doc.rust-lang.org/reference/items/enumerations.html#assigning-discriminant-values
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/enum_no_repr_variant_discriminant_changed.ron

Failed in:
  variant ContractActionsDiscriminants::Inspect 2 -> 3 in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/mod.rs:43
  variant ContractActionsDiscriminants::DownloadAbi 3 -> 4 in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/mod.rs:46
  variant ContractActionsDiscriminants::DownloadWasm 4 -> 5 in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/mod.rs:49
  variant ContractActionsDiscriminants::ViewStorage 5 -> 6 in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/mod.rs:52
  variant ContractActionsDiscriminants::Inspect 2 -> 3 in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/mod.rs:43
  variant ContractActionsDiscriminants::DownloadAbi 3 -> 4 in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/mod.rs:46
  variant ContractActionsDiscriminants::DownloadWasm 4 -> 5 in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/mod.rs:49
  variant ContractActionsDiscriminants::ViewStorage 5 -> 6 in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/mod.rs:52

--- failure enum_variant_added: enum variant added on exhaustive enum ---

Description:
A publicly-visible enum without #[non_exhaustive] has a new variant.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#enum-variant-new
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/enum_variant_added.ron

Failed in:
  variant ContractActionsDiscriminants:DeployAsGlobal in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/mod.rs:38
  variant ContractActionsDiscriminants:DeployAsGlobal in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/mod.rs:38
  variant CliActionSubcommand:DeployGlobalContract in /tmp/.tmpg27DR7/near-cli-rs/src/commands/transaction/construct_transaction/add_action_1/add_action/mod.rs:20
  variant CliActionSubcommand:UseGlobalContract in /tmp/.tmpg27DR7/near-cli-rs/src/commands/transaction/construct_transaction/add_action_1/add_action/mod.rs:20
  variant ActionSubcommand:DeployGlobalContract in /tmp/.tmpg27DR7/near-cli-rs/src/commands/transaction/construct_transaction/add_action_1/add_action/mod.rs:61
  variant ActionSubcommand:UseGlobalContract in /tmp/.tmpg27DR7/near-cli-rs/src/commands/transaction/construct_transaction/add_action_1/add_action/mod.rs:66
  variant CliContractActions:DeployAsGlobal in /tmp/.tmpg27DR7/near-cli-rs/src/commands/contract/mod.rs:18
  variant ActionSubcommandDiscriminants:DeployGlobalContract in /tmp/.tmpg27DR7/near-cli-rs/src/commands/transaction/construct_transaction/add_action_1/add_action/mod.rs:61
  variant ActionSubcommandDiscriminants:UseGlobalContract in /tmp/.tmpg27DR7/near-cli-rs/src/commands/transaction/construct_transaction/add_action_1/add_action/mod.rs:66
  variant ActionSubcommandDiscriminants:DeployGlobalContract in /tmp/.tmpg27DR7/near-cli-rs/src/commands/transaction/construct_transaction/add_action_1/add_action/mod.rs:61
  variant ActionSubcommandDiscriminants:UseGlobalContract in /tmp/.tmpg27DR7/near-cli-rs/src/commands/transaction/construct_transaction/add_action_1/add_action/mod.rs:66

--- failure struct_pub_field_missing: pub struct's pub field removed or renamed ---

Description:
A publicly-visible struct has at least one public field that is no longer available under its prior name. It may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.41.0/src/lints/struct_pub_field_missing.ron

Failed in:
  field use_file of struct CliContract, previously in file /tmp/.tmporyarC/near-cli-rs/src/commands/contract/deploy/mod.rs:5
  field signer_public_key of struct CliSignPrivateKey, previously in file /tmp/.tmporyarC/near-cli-rs/src/transaction_signature_options/sign_with_private_key/mod.rs:9
  field signer_public_key of struct InteractiveClapContextScopeForSignPrivateKey, previously in file /tmp/.tmporyarC/near-cli-rs/src/transaction_signature_options/sign_with_private_key/mod.rs:9
  field signer_public_key of struct SignPrivateKey, previously in file /tmp/.tmporyarC/near-cli-rs/src/transaction_signature_options/sign_with_private_key/mod.rs:15
```

<details><summary><i><b>Changelog</b></i></summary><p>

<blockquote>

##
[0.20.0](v0.19.0...v0.20.0)
- 2025-05-13

### Added

- display global contracts info on account details query
([#483](#483))
- extended action builder with new released items
([#457](#457))
- deploy and use global contracts from UI excluding action builder.
([#456](#456))
- Do not require to explicitly provide public key during signing
transactions with a plaintext private key (we can always extract it from
the private key) ([#468](#468))
- Added new command "get public key from plaintext private key"
([#466](#466))
- Use free ARM64 GitHub Action runners for pre-built binaries
([#454](#454))

### Fixed

- Fixed returning the result of a function call
([#462](#462))
- Fixed canceling the CLI operation in retry prompts
([#478](#478))
- Fixed cli command `near tokens send-ft` without `memo`
([#474](#474))
- allow forks to leverage transfer-to-project workflow
([#464](#464))

### Other

- removed unsupported reconstruction for DeployGlobalContract
([#484](#484))
- [**breaking**] updates near-* dependencies to 0.30 release
([#481](#481))
- fixed reconstruction of transaction from contract deploy
([#476](#476))
- Refactored 'send-ft memo' command from using Option<String> to just
String ([#477](#477))
- Replaced Linux x86-64 ubuntu-20.04 build environment with ubuntu-22.04
as 20.04 reached its end of life, so minimal supported glibc for
pre-built binaries is now 2.35 - Linux users with older glibc will have
to install CLIs from the source code or update their OS
([#470](#470))
- updated GUIDE ([#469](#469))
- Updated CI secret name in the devtools pipeline
([#460](#460))
</blockquote>


</p></details>

---
This PR was generated with
[release-plz](https://github.com/release-plz/release-plz/).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Shipped 🚀
Development

Successfully merging this pull request may close these issues.

4 participants