feat: extract `near-verify-rs` dependency #320

dj8yfo · 2025-03-27T20:21:22Z

No description provided.

…source_id`

…r-build/src/near/docker_build/subprocess_step.rs

…ar_verify_rs]

…>] to BuildInfoMixed

…a [camino::Utf8PathBuf]

…:CONTRACT_PATH] in `container_paths::Paths`

…pes::nep330::ContractSourceMetadata]

dj8yfo · 2025-04-01T20:18:24Z

@race-of-sloths include

race-of-sloths · 2025-04-01T20:19:10Z

@dj8yfo Thank you for your contribution! Your pull request is now a part of the Race of Sloths!

Current status: executed

Reviewer	Score
@frol	13

Your contribution is much appreciated with a final score of 13!
You have received 186 (130 base + 25 weekly bonus + 20% lifetime bonus) Sloth points for this contribution

@frol received 25 Sloth Points for reviewing and scoring this pull request.

Another weekly streak completed, well done @dj8yfo! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

Tag @race-of-sloths inside your pull requests
Wait for the maintainer to review and score your pull request
Check out your position in the Leaderboard
Keep weekly and monthly streaks to reach higher positions
Boast your contributions with a dynamic picture of your Profile

For maintainers:

Score pull requests that participate in the Race of Sloths and receive a reward
Engage contributors with fair scoring and fast responses so they keep their streaks
Promote the Race to the point where the Race starts promoting you
Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands

For contributors
- Include a PR: @race-of-sloths include to enter the Race with your PR
For maintainers:
- Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
- Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
- Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
- Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

…verify-rs`

dj8yfo · 2025-04-02T10:46:59Z

cargo-near-build/src/near/build/mod.rs

@@ -55,6 +55,14 @@ pub fn run(args: Opts) -> eyre::Result<CompilationArtifact> {
        )
    })?;

+    // addition of this check wasn't a change in logic, as previously output path was
+    // assumed without `--out-dir` too, so docker-build was just failing if the arg was supplied:


log output before when attempting to use --out-dir:

[package.metadata.near.reproducible_build] //... container_build_command = [ "cargo", "near", "build", "non-reproducible-wasm", "--locked", "--out-dir", "./custom_dir" ]

✓ Running docker command step (finished) • Copying artifact from temporary build site... artifact search location in temporary build site: /tmp/.tmplMHMxh/target/near • failed Here is the console command if you ever need to re-run it again: cargo near build reproducible-wasm Error: 0: Temporary build site result wasm file not found: `"/tmp/.tmplMHMxh/target/near/simple_package.wasm"`. Location: cargo-near-build/src/types/near/docker_build/cloned_repo.rs:134

I don't understand why we must forbid --out-dir. Just let it fail to find the wasm file at the end of the execution and force the user to provide the path explicitly in the [package.metadata.near.reproducible_build] section.

Are you trying to minimize the number of configurable options in the [package.metadata.near.reproducible_build] section? If that is the case, I get it, and it is fine to move forward like this. However, it might be more flexible to have a way to allow users to specify where to find the wasm file.

…p on near-verify-rs by default

frol

@dj8yfo Tremendous job!

@race-of-sloths score 55

frol · 2025-04-07T17:58:58Z

cargo-near-build/src/near/build/mod.rs

@@ -55,6 +55,14 @@ pub fn run(args: Opts) -> eyre::Result<CompilationArtifact> {
        )
    })?;

+    // addition of this check wasn't a change in logic, as previously output path was
+    // assumed without `--out-dir` too, so docker-build was just failing if the arg was supplied:


I don't understand why we must forbid --out-dir. Just let it fail to find the wasm file at the end of the execution and force the user to provide the path explicitly in the [package.metadata.near.reproducible_build] section.

Are you trying to minimize the number of configurable options in the [package.metadata.near.reproducible_build] section? If that is the case, I get it, and it is fine to move forward like this. However, it might be more flexible to have a way to allow users to specify where to find the wasm file.

race-of-sloths · 2025-04-07T18:00:40Z

🏆 Score recorded!

It looks like @frol provided a score of 55, but based on our Fibonacci scoring rules, we've adjusted it to 13.

Tip

We accept only the following Fibonacci numbers [0, 1, 2, 3, 5, 8, 13] for scoring

## 🤖 New release * `cargo-near-build`: 0.4.5 -> 0.4.6 (⚠ API breaking changes under `test-code` feature) * `cargo-near`: 0.13.5 -> 0.13.6 (✓ API compatible changes) ### ⚠ `cargo-near-build` breaking changes ```text --- failure inherent_method_missing: pub method removed or renamed --- Description: A publicly-visible method or associated fn is no longer available under its prior name. It may have been renamed or removed entirely. ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.40.0/src/lints/inherent_method_missing.ron Failed in: CrateMetadata::resolve_output_dir, previously in file /tmp/.tmpC134jK/cargo-near-build/src/types/cargo/metadata.rs:62 ``` <details><summary>Changelog</summary> ## `cargo-near-build` <blockquote> ## [0.4.6](cargo-near-build-v0.4.5...cargo-near-build-v0.4.6) - 2025-04-08 ### Added - extract `near-verify-rs` dependency ([#320](#320)) </blockquote> ## `cargo-near` <blockquote> ## [0.13.6](cargo-near-v0.13.5...cargo-near-v0.13.6) - 2025-04-08 ### Added - extract `near-verify-rs` dependency ([#320](#320)) ### Other - update `cargo near new` template `image` and `image_digest` ([#318](#318)) </blockquote> </details> --- This PR was generated with [release-plz](https://github.com/release-plz/release-plz/). --------- Co-authored-by: dj8yf0μl <noreply@nowhere.org>

dj8yfo changed the title ~~feat: extract near-verify-rs dependey~~ feat: extract near-verify-rs dependency Mar 27, 2025

dj8yfo marked this pull request as ready for review March 28, 2025 17:10

dj8yfo requested review from FroVolod, akorchyn and PolyProgrammist as code owners March 28, 2025 17:10

dj8yfo marked this pull request as draft March 31, 2025 10:54

dj8yf0μl added 24 commits March 31, 2025 13:56

move out source_id module

ba166e4

tidy up docker_command module

f40a813

split away docker_checks from docker_command as a peer module

3f01184

move out docker_checks and docker_command modules

e65f9ae

adjust for source_id import path change to `near_verify_rs::types::…

fe81638

…source_id`

rename BuildInfo -> BuildInfoMixed; move into it a field of NEP_330_LINK

5bf4474

markup todo-s

a0891de

add build_command to BuildInfoMixed

c709747

move out [BuildInfoMixed::new] before run in cargo-near/cargo-nea…

df9272b

…r-build/src/near/docker_build/subprocess_step.rs

remove dependency on docker_build_meta arg in subprocess_step::run

22ae5df

extract this build_command transform rule as a public function on [ne…

57381e9

…ar_verify_rs]

make [env_keys::nep330::LINK] computation rule less abstraction leaky

44a352c

add field for [env_keys::nep330::VERSION] env variable [Option<String…

5f05db1

…>] to BuildInfoMixed

add contract_source_workdir argument to subprocess_step::run as …

138eddb

…a [camino::Utf8PathBuf]

perform a computation of relative path from [crate::env_keys::nep330:…

f854abc

…:CONTRACT_PATH] in `container_paths::Paths`

markup todo-s

9c75879

RUST_LOG=info: replace with additional_docker_args parameter usage

36e8616

move BuildInfoMixed::new call

2f163be

set input params for subprocess_step::run to be [near_verify_rs::ty…

9322f7a

…pes::nep330::ContractSourceMetadata]

move out [env_keys::nep330] to [near_verify_rs]

cc1037e

move out docker_env_args method

bc477ac

move out [container_paths] module to [near_verify_rs::types::internal]

5d1e10a

move out subprocess_step::run to [near_verify_rs::logic::nep330_build]

1bdc159

remove completed todo about copying out ManifestPath and CargoMetadata

070f686

update rev to a1afc8e

3ec9294

dj8yfo marked this pull request as ready for review March 31, 2025 12:10

dj8yf0μl added 2 commits April 1, 2025 18:10

change origin of git dep dj8yfo -> near

71cc4c1

update rev to 57a9412

03033b8

This was referenced Apr 1, 2025

add .github/workflows/release-plz.yml near/near-verify-rs#1

Closed

add .github/workflows/release-plz.yml near/near-verify-rs#2

Merged

update near-verify-rs to version from crates.io

1aebcdf

dj8yfo marked this pull request as draft April 1, 2025 20:46

dj8yf0μl added 3 commits April 2, 2025 00:08

add a few todo-s

98801a1

replace output wasm path computation with the same logic as in `near-…

1f10a67

…verify-rs`

add rule forbidding to use --out-dir inside docker

226aba9

dj8yfo commented Apr 2, 2025

View reviewed changes

dj8yf0μl added 5 commits April 2, 2025 14:22

clippy

06fb125

group out dir/wasm path computation everywhere

7076f96

group abi_filenames compute to [crate::types::nearOutputPaths] too

d52534b

fix imports error on #[cfg(not(test)]

60e97a1

extract [OutputPaths::intermediate_abi_path]

777e7cb

dj8yfo marked this pull request as ready for review April 2, 2025 20:32

dj8yf0μl added 2 commits April 4, 2025 22:40

remove re-export of [near_verify_rs::env_keys] by default to avoid de…

1fea4a5

…p on near-verify-rs by default

cargo-audit: update openssl

656b87d

frol approved these changes Apr 7, 2025

View reviewed changes

dj8yfo mentioned this pull request Apr 7, 2025

feat: populate output_wasm_path into ContractSourceMetadata #323

Merged

2 tasks

Merge branch 'main' into feat/near-verify-rs-extract

91fac3d

dj8yfo enabled auto-merge (squash) April 8, 2025 05:34

dj8yfo merged commit 6596bbf into near:main Apr 8, 2025
18 checks passed

frol mentioned this pull request Apr 7, 2025

chore: release #319

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat: extract `near-verify-rs` dependency #320

feat: extract `near-verify-rs` dependency #320

Uh oh!

dj8yfo commented Mar 27, 2025

Uh oh!

dj8yfo commented Apr 1, 2025

Uh oh!

race-of-sloths commented Apr 1, 2025 •

edited

Loading

Uh oh!

dj8yfo Apr 2, 2025 •

edited

Loading

Uh oh!

frol Apr 7, 2025

Uh oh!

frol left a comment

Uh oh!

frol Apr 7, 2025

Uh oh!

race-of-sloths commented Apr 7, 2025

Uh oh!

Uh oh!

Uh oh!

feat: extract near-verify-rs dependency #320

feat: extract near-verify-rs dependency #320

Uh oh!

Conversation

dj8yfo commented Mar 27, 2025

Uh oh!

dj8yfo commented Apr 1, 2025

Uh oh!

race-of-sloths commented Apr 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dj8yfo Apr 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

frol Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

frol left a comment

Choose a reason for hiding this comment

Uh oh!

frol Apr 7, 2025

Choose a reason for hiding this comment

Uh oh!

race-of-sloths commented Apr 7, 2025

🏆 Score recorded!

Uh oh!

Uh oh!

Uh oh!

feat: extract `near-verify-rs` dependency #320

feat: extract `near-verify-rs` dependency #320

race-of-sloths commented Apr 1, 2025 •

edited

Loading

dj8yfo Apr 2, 2025 •

edited

Loading