feat: halt wrong building #350
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently contracts need to be compiled using `cargo near build`, since using `cargo build` will end up in a built contract that cannot be used This commit adds a `build.rs` file that forces users to use `cargo near build`, which will set a unique ENV VAR
|
Here is the main idea, but I need somebody to take over. I created the changes on a branch of this repo so anyone from the project can take over. The only missing part is: making |
|
Looks like building with plain |
|
We ran a hackathon last week and literally every single team (they were 20 in total) had an issue with this
I got pinged by devs about this today, and accordingly to our statistics, more than a hundred rust contracts are created per week
I would strongly to enforce it for now, since it greatly hurts the dev experience
|
|
@frol has also asked to leave this as last resort, I'll close it now and only implement it in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently contracts need to be compiled using
cargo near build, since usingcargo buildwill end up in a built contract that cannot be usedThis PR adds a
build.rsfile that forces users to usecargo near build, and configurescargo nearto set a uniqueENVIRONMENTAL VARIABLEwhen building