chore(mappings): add unsynced lyrics to default mapping #3997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 630164f in 1 minute and 0 seconds. Click for details.
- Reviewed
13lines of code in1files - Skipped
0files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. resources/mappings.yaml:110
- Draft comment:
Added 'unsyncedlyrics' alias to the lyrics mapping. Verify that the alias follows existing naming conventions. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. resources/mappings.yaml:111
- Draft comment:
Nicely added alias for unsynced lyrics. This enhances tag compatibility for FLAC and similar formats. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. resources/mappings.yaml:46
- Draft comment:
Typo detected: In the comment in the composer alias block, 'tagss' should be corrected to 'tags'. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
Workflow ID: wflow_qUirnmhWyqfVzQqr
You can customize 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something I just found out, but some taggers also add
unsyncedlyrics(e.g., flac) for unsynced lyrics (instead of justlyrics). Add this to the default mapping (since I think it just makes sense).