Skip to content

check if aiff file has cover art #3996

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 25, 2025
Merged

check if aiff file has cover art #3996

merged 3 commits into from
Apr 25, 2025

Conversation

kgarner7
Copy link
Contributor

Resolves #3992

ellipsis-dev[bot]
ellipsis-dev bot reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to f4d1cd0 in 41 seconds. Click for details.
  • Reviewed 22 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 2 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. adapters/taglib/taglib_wrapper.cpp:240
  • Draft comment:
    Good addition for AIFF support. Ensure that using aiffFile->tag() is equivalent to calling an ID3v2 accessor (as done in the read section) for consistency.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50% None
2. adapters/taglib/taglib_wrapper.cpp:240
  • Draft comment:
    The new AIFF branch correctly checks for cover art by inspecting the 'APIC' frame when an ID3v2 tag is present. For extra robustness, consider verifying that 'aiffFile->tag()' returns a non-null pointer before calling frameListMap(), in case the tag() method might ever return nullptr.
  • Reason this comment was not posted:
    Confidence changes required: 33% <= threshold 50% None

Workflow ID: wflow_zpuMdSpMXYyigW65

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 24, 2025 •
edited
Loading

Download the artifacts for this pull request:

@deluan
Copy link
Member

deluan commented Apr 24, 2025

Thanks! Should we add a small test for that?

@deluan
Copy link
Member

deluan commented Apr 25, 2025

Is ffmpeg able to extract the coverart from wavpak? It yes, we can leave it.

@kgarner7
Copy link
Contributor Author

Is ffmpeg able to extract the coverart from wavpak? It yes, we can leave it.

No. It sees the metadata, but fails to extract it (and in Navidrome, getCoverArt) failed to parse wavpak specifically. Perhaps a different command would work, but the extractImageCmd does not

@deluan deluan merged commit 0d1f2bc into navidrome:master Apr 25, 2025
31 checks passed
@kgarner7 kgarner7 deleted the check-aiff-cover-art branch April 26, 2025 13:22
@BrewTestBot BrewTestBot mentioned this pull request May 29, 2025
Merged
@github-actions GitHub Actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
1 more reviewer

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
frozen-due-to-age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Navidrome cannot load embedded album art form AIFF format
2 participants
@kgarner7 @deluan