Skip to content

fix(ui): Fix make dev #3795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 10, 2025
Merged

fix(ui): Fix make dev #3795

merged 2 commits into from
Mar 10, 2025

Conversation

kgarner7
Copy link
Contributor

  1. For some bizarre reason, importing inflection by itself is undefined. But you can import specific functions
  2. Per Service Worker works in dev, but in production get error Failed to execute 'importScripts' on ' vite-pwa/vite-plugin-pwa#419, type: 'module', is only for non-chromium browsers

1. For some bizarre reason, importing inflection by itself is undefined. But you can import specific functions
2. Per vite-pwa/vite-plugin-pwa#419, `type: 'module',` is only for non-chromium browsers
@bornav
Copy link
Contributor

bornav commented Mar 10, 2025

OP here, confirmed working with this

@deluan deluan merged commit a28462a into navidrome:master Mar 10, 2025
19 checks passed
@kgarner7 kgarner7 deleted the fix-make-dev branch March 10, 2025 18:51
Copy link

github-actions bot commented Jul 9, 2025

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants