Skip to content

Support for Original Date, Release Date & splitting/grouping of album editions #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 314 commits into from
May 19, 2023

Conversation

certuna
Copy link
Contributor

@certuna certuna commented Feb 11, 2023

Detailed explanation here: #278

Serverside:

  • reading of originaldate, date and releasedate tags as full dates, not just Year
  • mapping to Year/Date & Release Date fields in DB, including handling the 'special case' of MusicBrainz Picard-style tagging
  • optionally either separate or combine albums reissues, i.e. where Album Artist + Album Title is the same, but different release dates using Scanner.GroupAlbumReleases = "true" or "false"

Clientside (Web UI):

  • Album details: display Release Date when it is different from Date
  • Artist discography (gridview): display Release Date of the album when it is different from Date & display when there's multiple releases of an album
  • Album tracklist: when an album has multiple Release Dates, then add a separator row between the releases in the tracklist

Clientside (Subsonic):

  • no changes

Edit: everything done, ready for merging.

certuna added 7 commits April 19, 2023 16:40
AllOrNothing -> allOrNothing
Editions -> Releases
showReleaseRow -> showReleaseDivider
showReleaseRow -> showReleaseDivider for clarity
@deluan
Copy link
Member

deluan commented May 3, 2023

Seems that we are ready to fix conflicts (I can do that) and merge. Anything missing @certuna ?

@certuna
Copy link
Contributor Author

certuna commented May 17, 2023

Seems that we are ready to fix conflicts (I can do that) and merge. Anything missing @certuna ?

Think we're all done, tests are all OK now too.

@deluan deluan merged commit 52b77e4 into navidrome:master May 19, 2023
@metalheim metalheim mentioned this pull request Jun 5, 2023
25 tasks
@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants