Skip to content

Display lyrics on UI, if synced lyrics present in metadata. Fixes GH #491. #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2021
Merged

Display lyrics on UI, if synced lyrics present in metadata. Fixes GH #491. #1406

merged 1 commit into from
Oct 19, 2021

Conversation

chiraglulla
Copy link
Contributor

Signed-off-by: Chirag Lulla lullachirag239@gmail.com

@chiraglulla
Display lyrics on UI if synced lyrics present in metadata
778ce3d 
Signed-off-by: Chirag Lulla <lullachirag239@gmail.com>
@chiraglulla chiraglulla marked this pull request as ready for review October 18, 2021 10:18
@deluan
Copy link
Member

deluan commented Oct 19, 2021

Thanks!! I haven't tried this yet, but I have a couple of questions:

  • What happens if the song does not have lyrics? Will the "show lyrics" button be disabled?
  • Can you please post a screenshot of how the lyrics shows up in mobile view?

@chiraglulla
Copy link
Contributor Author

  • What happens if the song does not have lyrics? Will the "show lyrics" button be disabled?
    If there is no synced lyric available for the song and when the show lyric button is clicked, it would show the text "No Lyric" to the user as in the image below.
    image

@deluan deluan merged commit 34b01c2 into navidrome:master Oct 19, 2021
@deluan
Copy link
Member

deluan commented Oct 19, 2021

Nice, LGTM! Thanks!

@deluan deluan mentioned this pull request Oct 19, 2021
Closed
@Extarys Extarys mentioned this pull request Oct 21, 2021
Closed
@chiraglulla
Copy link
Contributor Author

I & @dheerajdlalwani shall get working on this in some time.

@github-actions
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chiraglulla @deluan