fix(subsonic): only use genre tag when searching by genre #4361
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @kgarner7, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a bug in the Subsonic API's genre filtering mechanism. The previous implementation could lead to inaccurate search results by broadly matching any tag value against the requested genre. The fix refines this logic to ensure that genre-based searches, such as those used by getSongsByGenre and getRandomSongs, precisely filter by the designated genre tag, improving the accuracy and relevance of returned songs.
Highlights
- Bug Fix: Genre Filtering Accuracy: Corrected the
filterByGenrefunction to specifically target the$.genrefield within thetagsJSON structure. This prevents incorrect song matches that could occur if other non-genre tags coincidentally matched the genre search value (e.g., a tag named '1' matching a genre search for '1').
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request fixes a bug in genre filtering by specifying the $.genre path in the json_tree function, preventing mismatches with other tags. A suggestion has been added to further improve correctness by using an exact match for genres instead of a LIKE comparison, which can prevent unexpected behavior with certain genre names.
| return persistence.Exists(`json_tree(tags, "$.genre")`, And{ | ||
| Like{"value": genre}, | ||
| NotEq{"atom": nil}, | ||
| }) |
There was a problem hiding this comment.
Using Like for matching the genre can lead to unexpected behavior if a genre name contains SQL wildcard characters (_ or %). For example, a search for a genre named Rock_Roll would also match Rock-Roll. Using Eq for an exact match is safer and more accurately reflects the intent of filtering by a specific genre.
| return persistence.Exists(`json_tree(tags, "$.genre")`, And{ | |
| Like{"value": genre}, | |
| NotEq{"atom": nil}, | |
| }) | |
| return persistence.Exists(`json_tree(tags, "$.genre")`, And{ | |
| Eq{"value": genre}, | |
| NotEq{"atom": nil}, | |
| }) |
Description
Currently, Subsonic api
filterByGenre(used bygetSongsByGenreandgetRandomSongs?genre=...) checks if any tag matches the genre. This is a problem if the genre value matches another tag (for example, 1). Only look at$.genreinstead.Related Issues
Type of Change
Checklist
Please review and check all that apply:
How to Test
No new test (
album_list_test.gois not end-to-end).genre1(or, any other conflicting value).getSongsByGenre?genre=$genre.Screenshots / Demos (if applicable)
N/A
Additional Notes
N/A