-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix(ui): update Danish, German, Greek, Spanish, Finnish, French, Indonesian, Russian, Slovenian, Swedish, Turkish, Ukrainian translations from POEditor #4326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @deluan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request automates the process of keeping the application's user interface localized by pulling the latest Finnish and Ukrainian translations from POEditor. It introduces new translated strings for recently added features and fills in previously missing translations, ensuring a more complete and up-to-date multilingual experience for users.
Highlights
- Automated Translation Updates: This pull request contains automated updates for Finnish (
fi.json
) and Ukrainian (uk.json
) UI translations, sourced from POEditor. - Expanded Finnish Translations: The Finnish translation file (
fi.json
) has been significantly updated to include new strings for various UI components, such as playlist actions ('showInPlaylist', 'saveQueue', 'searchOrCreate'), configuration settings ('tabs', 'config' section), and the 'Now Playing' section. Several previously empty translation keys like 'missing', 'saveQueue', and 'remove_all' have also been filled. - Ukrainian Translation Additions: The Ukrainian translation file (
uk.json
) has received new keys for similar UI elements, including playlist actions ('showInPlaylist', 'searchOrCreate'), configuration settings ('tabs', 'config' section), and the 'Now Playing' section. It's notable that some of these new keys are introduced with empty string values, indicating they are placeholders to be filled in future updates.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Updating Finnish and Ukrainian localization files with new keys and translations from POEditor.
- Ukrainian (uk.json): Added UI keys (e.g., showInPlaylist, tabs, config), updated messages, but several values remain empty.
- Finnish (fi.json): Filled previously blank entries, added new keys, and corrected punctuation.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
File | Description |
---|---|
resources/i18n/uk.json | Added new Ukrainian keys (tabs, config, nowPlaying) and commas; some values are still empty. |
resources/i18n/fi.json | Filled missing Finnish translations for many keys and added new entries. |
Comments suppressed due to low confidence (1)
resources/i18n/fi.json:539
- The key "status" appears to require a generic status label, but the translation "Skannausvirhe" means "scan error." Please verify and adjust to match the intended context (e.g., "Tila").
"status": "Skannausvirhe",
resources/i18n/uk.json
Outdated
@@ -123,7 +124,13 @@ | |||
"mixer": "Звукоінженер |||| Звукоінженери", | |||
"remixer": "Реміксер |||| Реміксери", | |||
"djmixer": "DJ-звукоінженер |||| DJ-звукоінженери", | |||
"performer": "Виконавець |||| Виконавці" | |||
"performer": "Виконавець |||| Виконавці", | |||
"maincredit": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation for "maincredit" is empty, which will display nothing in the UI. Please provide the appropriate Ukrainian translation for this key.
"maincredit": "" | |
"maincredit": "Головний автор" |
Copilot uses AI. Check for mistakes.
resources/i18n/uk.json
Outdated
"shuffle": "", | ||
"radio": "", | ||
"topSongs": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "shuffle" action label is missing its translation and will render as an empty string—please add the correct Ukrainian text. The same applies to "radio" and "topSongs" keys.
"shuffle": "", | |
"radio": "", | |
"topSongs": "" | |
"shuffle": "Перемішати", | |
"radio": "Радіо", | |
"topSongs": "Топ пісні" |
Copilot uses AI. Check for mistakes.
resources/i18n/uk.json
Outdated
"song_exist": "У список відтворення додаються дублікати. Хочете додати дублікати або пропустити їх?" | ||
"song_exist": "У список відтворення додаються дублікати. Хочете додати дублікати або пропустити їх?", | ||
"noPlaylistsFound": "Не знайдено плейлистів", | ||
"noPlaylists": "Жодного плейлисту не " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This translation ends with a trailing space and appears incomplete. Please provide the full Ukrainian message for "noPlaylists".
"noPlaylists": "Жодного плейлисту не " | |
"noPlaylists": "Жодного плейлисту не знайдено" |
Copilot uses AI. Check for mistakes.
resources/i18n/uk.json
Outdated
@@ -430,7 +443,9 @@ | |||
"remove_missing_title": "Видалити зниклі файли", | |||
"remove_missing_content": "Ви впевнені, що хочете видалити вибрані відсутні файли з бази даних? Це назавжди видалить усі посилання на них, включаючи кількість прослуховувань та рейтинги.", | |||
"remove_all_missing_title": "Видалити всі відсутні файли", | |||
"remove_all_missing_content": "Ви впевнені, що хочете видалити всі відсутні файли з бази даних? Це назавжди видалить будь-які посилання на них, включно з кількістю відтворень та рейтингами." | |||
"remove_all_missing_content": "Ви впевнені, що хочете видалити всі відсутні файли з бази даних? Це назавжди видалить будь-які посилання на них, включно з кількістю відтворень та рейтингами.", | |||
"noSimilarSongsFound": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The translation for "noSimilarSongsFound" is empty, causing an empty UI label. Please supply the appropriate Ukrainian text.
"noSimilarSongsFound": "", | |
"noSimilarSongsFound": "Схожі пісні не знайдено", |
Copilot uses AI. Check for mistakes.
resources/i18n/uk.json
Outdated
@@ -522,5 +552,10 @@ | |||
"toggle_love": "Відмітити поточні пісні", | |||
"current_song": "Перейти до поточної пісні" | |||
} | |||
}, | |||
"nowPlaying": { | |||
"title": "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "nowPlaying.title" translation is empty, so the now playing header will be blank—please add the Ukrainian translation.
"title": "", | |
"title": "Зараз грає", |
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates Finnish and Ukrainian translation files. The Finnish translations are mostly complete and correct, with a couple of minor suggestions. However, the Ukrainian translation file introduces several new keys with empty or incomplete strings. This will lead to a mixed-language UI for Ukrainian users. These missing translations should be addressed before this PR is merged to ensure a quality user experience.
resources/i18n/uk.json
Outdated
"song_exist": "У список відтворення додаються дублікати. Хочете додати дублікати або пропустити їх?" | ||
"song_exist": "У список відтворення додаються дублікати. Хочете додати дублікати або пропустити їх?", | ||
"noPlaylistsFound": "Не знайдено плейлистів", | ||
"noPlaylists": "Жодного плейлисту не " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resources/i18n/uk.json
Outdated
"maincredit": "" | ||
}, | ||
"actions": { | ||
"shuffle": "", | ||
"radio": "", | ||
"topSongs": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The new translation keys maincredit
, shuffle
, radio
, and topSongs
have empty values. This indicates that the translations are missing. While the application may fall back to English for these, it leads to an inconsistent user experience with mixed languages. These keys should be translated into Ukrainian before merging.
resources/i18n/uk.json
Outdated
"noSimilarSongsFound": "", | ||
"noTopSongsFound": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
resources/i18n/uk.json
Outdated
"title": "", | ||
"empty": "", | ||
"minutesAgo": "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"status": "", | ||
"elapsedTime": "" | ||
"scanType": "Tyyppi", | ||
"status": "Skannausvirhe", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fdabf76
to
cb0cb80
Compare
b271f8f
to
77c0498
Compare
47c384f
to
c4a9f76
Compare
c4a9f76
to
ddfacf5
Compare
7dcbbe2
to
5ce9ed8
Compare
b577c33
to
ebd5e15
Compare
ebd5e15
to
b702753
Compare
…nesian, Russian, Slovenian, Swedish, Turkish, Ukrainian translations from POEditor
b702753
to
52ca238
Compare
Automated changes by create-pull-request GitHub action