Hungarian: added new strings #4291
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @ChekeredList71, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request is dedicated to updating and expanding the Hungarian localization of the application. It introduces a comprehensive set of new translation strings across various functional areas, ensuring a more complete and accurate user interface for Hungarian-speaking users.
Highlights
- Localization Update: This pull request introduces a significant number of new Hungarian translation strings to the
resources/i18n/hu.jsonfile, expanding the localized content for various parts of the application. - UI Element Translations: New strings have been added to cover previously untranslated or new UI elements, including playlist actions (e.g., 'show in playlist'), artist credits, and prompts for searching or creating playlists.
- System and Configuration Messages: Translations for system messages like 'no similar songs found' and 'no top songs found' are included. Additionally, new strings for 'About' and 'Config' tabs, configuration display, and the 'Now Playing' section have been added, enhancing the user experience for Hungarian speakers in these areas.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request adds new Hungarian translations. There are critical JSON syntax errors due to missing commas, which will prevent the application from parsing the translation file correctly. There is also a grammatical error in one of the new strings.
| @@ -41,6 +41,7 @@ | |||
| "addToQueue": "Lejátszás útolsóként", | |||
| "playNow": "Lejátszás", | |||
| "addToPlaylist": "Lejátszási listához adás", | |||
| "showInPlaylist": "Megjelenítés a lejátszási listában", | |||
There was a problem hiding this comment.
The preceding line (43) is missing a trailing comma, which is required between key-value pairs in a JSON object. This will cause parsing errors.
There was a problem hiding this comment.
AI hallucinated
| "noSimilarSongsFound": "Nem találhatóak hasonló számok", | ||
| "noTopSongsFound": "Nincsenek top számok", |
There was a problem hiding this comment.
The preceding line (416) is missing a trailing comma, which is required. This will cause parsing errors.
There was a problem hiding this comment.
AI hallucinated
resources/i18n/hu.json
Outdated
| @@ -509,6 +539,11 @@ | |||
| "status": "Szkennelési hiba", | |||
| "elapsedTime": "Eltelt idő" | |||
| }, | |||
| "nowPlaying": { | |||
| "title": "Most megy", | |||
| "empty": "Nem játszas le semmit", | |||
There was a problem hiding this comment.
This line is missing a trailing comma, which is required before the next key-value pair on line 545. This will cause the application to fail when parsing this file. Also, the word "játszas" is grammatically incorrect and should be "játszol".
"empty": "Nem játszol le semmit",
There was a problem hiding this comment.
"játszasz" and "játszol" are both correct, but "játszasz" is more common. Although "hallgatsz" (~listening) would fit better here. I'll edit it.
Edit:
TIL játszol is the official and the other is regional.
|
Never saw Gemini hallucinate with JSON syntax, like this. Well, thanks! |
Description
new strings from the comparison of d903d3f and 4909232.
Related Issues
None.
Type of Change
Checklist
Please review and check all that apply:
Just, no.
How to Test
Look at it.