Clear dangling music from BFR migration #4262
Conversation
Signed-off-by: Deluan <deluan@navidrome.org>
Signed-off-by: Deluan <deluan@navidrome.org>
There was a problem hiding this comment.
Summary of Changes
Hello @deluan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request provides a crucial fix for a data integrity issue that can arise when upgrading Navidrome from very old versions (pre-BFR). It introduces a database migration that identifies and flags 'dangling' or duplicated music files and albums as missing, allowing users to properly remove these unreferenced entries and maintain a clean music library.
Highlights
- Database Migration for Data Cleanup: Introduced a new database migration script (
20250701010105_remove_dangling_items.sql) to address data inconsistencies from older Navidrome upgrades. This script marksmedia_fileentries with an emptyfolder_idandalbumentries with emptyfolder_idsasmissing=1, making them visible for cleanup in the 'Missing Files' view. - Build Artifact Ignore Rule Update: Modified the
.gitignorefile to broaden the pattern for ignoring Navidrome build artifacts fromnavidrome-mastertonavidrome-*, accommodating more general build output names.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Pull Request Overview
This PR adds a database migration to mark previously dangling media files and albums as missing after upgrading from pre-BFR versions.
- Adds an
Upmigration to flag orphanedmedia_fileandalbumrecords as missing - Targets files with empty
folder_idor emptyfolder_idsarrays
There was a problem hiding this comment.
Code Review
This pull request addresses an issue with dangling music items from older versions by introducing a database migration to mark them as missing. The change in .gitignore is a good improvement for ignoring build artifacts. The SQL migration correctly identifies dangling media files and albums and flags them, which should resolve the issue as described. I have one minor suggestion to improve the clarity of the migration script.
When upgrading from version 0.54.5 or older (pre-BFR), there are some edge cases that can cause albums and songs to be duplicated in a library, and because of bad DB relationships, they are never deleted/marked as missing, with no way to removing them from the DB.
This PR marks these items as missing on startup, so they become deletable from the Missing Files view.
Should fix #4081