feat(many): Expose primary stat to reflet only album artist | artist credit
#4268
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @kgarner7, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a primary stat to represent artist credits accurately, particularly for album artists and artists. It enhances the Subsonic API by exposing this stat when ArtistParticipations is enabled and integrates it into the Navidrome UI with corresponding sorting options. The changes also include a database migration to update artist statistics and refactor the getArtistAlbumCount function.
Highlights
- New
primarystat: Introduces a newprimarystat to reflect artist credits as album artist or artist, enhancing accuracy in artist statistics. - Subsonic API Enhancement: Exposes the
primarystat for Subsonic API whenArtistParticipationsis enabled, providing more accurate album and song counts. - Navidrome UI Integration: Adds
primaryrole to Navidrome UI and introduces manualprimary*sorts for sorting by available credits. - Database Migration: Includes a database migration to update artist statistics with the new
primaryrole. - Code Refactoring: Refactors
getArtistAlbumCountfunction to utilizeprimaryStatswhenArtistParticipationsis enabled.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces a 'primary' stat to reflect album artist/artist credits, enhancing the accuracy of artist statistics in Navidrome and Subsonic APIs. The changes include modifications to database migrations, model definitions, repository logic, and UI components to incorporate this new stat. The review focuses on code correctness, efficiency, and maintainability, with suggestions for clarifying logic, reducing code duplication, and ensuring consistency across the codebase.
persistence/artist_repository.go
Outdated
| // Create a single parameter array with all IDs (repeated 3 times for each IN clause) | ||
| // We need to repeat each ID 3 times (once for each IN clause) | ||
| var args []interface{} | ||
| for _, id := range artistIDBatch { | ||
| args = append(args, id) // For ROLE_IDS_PLACEHOLDER | ||
| } | ||
| for _, id := range artistIDBatch { | ||
| args = append(args, id) // For TOTAL_IDS_PLACEHOLDER | ||
| } | ||
| for _, id := range artistIDBatch { | ||
| args = append(args, id) // For UPDATE_IDS_PLACEHOLDER | ||
| } | ||
| args := make([]any, 4*len(artistIDBatch)) | ||
| for i := range 4 { | ||
| startIdx := i * len(artistIDBatch) | ||
|
|
||
| for idx, id := range artistIDBatch { | ||
| args[startIdx+idx] = id | ||
| } | ||
| } |
There was a problem hiding this comment.
Instead of manually calculating the start index and iterating, consider using copy to simplify the logic and potentially improve performance.
Also, the comment says "repeated 3 times", but the code repeats it 4 times.
args := make([]any, 4*len(artistIDBatch))
for i, id := range artistIDBatch {
args[i] = id // For ROLE_IDS_PLACEHOLDER
args[len(artistIDBatch)+i] = id // For TOTAL_IDS_PLACEHOLDER
args[2*len(artistIDBatch)+i] = id // For UPDATE_IDS_PLACEHOLDER
args[3*len(artistIDBatch)+i] = id // For UPDATE_IDS_PLACEHOLDER
}
Since both ND API and Subsonic API (with
ArtistParticipations) expose artist songs/albums where the artist is credited as an album artist or artist, add a new statprimaryto reflect this.Expose this for Subsonic when
ArtistParticipationsis true (to get accurate album count/song count).Expose this for Navidrome as another role
primary, also in the UI, and add manualprimary*sorts to sort only by credits that Navidrome can return.