Fix clearing playlist comment in Subsonic API #4258
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @deluan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request resolves a functional bug in the Subsonic API's updatePlaylist endpoint, ensuring that users can now explicitly clear a playlist's comment by providing an empty comment parameter. The change involves a precise modification to the parameter parsing logic within the API handler and is thoroughly validated by newly introduced unit tests, improving the robustness and correctness of the API.
Highlights
- API Fix: The
UpdatePlaylistendpoint in the Subsonic API now correctly interprets an emptycomment=query parameter as an instruction to clear the playlist's comment. Previously, an emptycommentparameter would be ignored, preventing users from clearing existing comments via the API. - Test Coverage: New unit tests have been added in
server/subsonic/playlists_test.goto specifically validate the behavior of theUpdatePlaylisthandler. These tests cover scenarios where thecommentparameter is provided as an empty string (to ensure clearing) and when it is entirely missing (to ensure no change).
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Signed-off-by: Deluan <deluan@navidrome.org>
Signed-off-by: Deluan <deluan@navidrome.org>
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue of clearing the playlist comment via the Subsonic API, ensuring that an empty "comment" parameter correctly clears the comment and adding tests for this behavior.
- Updated request helper functions to support pointer-based parameter retrieval
- Modified the Subsonic API playlist update to use the new helper functions
- Added tests covering string and boolean parameter edge cases
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| utils/req/req.go | Added StringPtr and BoolPtr functions for parameter handling |
| utils/req/req_test.go | Added tests for the new helper functions |
| server/subsonic/playlists.go | Updated UpdatePlaylist to use pointer-based parameter retrieval |
| server/subsonic/playlists_test.go | Added tests for clearing comments and public flag handling |
Comments suppressed due to low confidence (1)
utils/req/req.go:38
- Add function-level comments for StringPtr (and similarly for BoolPtr) to clarify their intended behavior and edge-case handling.
func (r *Values) StringPtr(param string) *string {
Summary
updatePlaylistto clear playlist comment whencomment=is providedTesting
make lintmake testhttps://chatgpt.com/codex/tasks/task_b_685a757a4a08832e88ab8383a5740427