-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
fix: update GoReleaser configurations #4234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @emmanuel-ferdman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request addresses a deprecation warning in the GoReleaser configuration by updating the syntax for specifying archive formats for Windows builds. The change is minimal but necessary to maintain compatibility and silence build warnings.
Highlights
- Configuration Update: Updated the GoReleaser configuration file (
release/goreleaser.yml
) to use the newformats
key instead of the deprecatedformat
key within thearchives.format_overrides
section for Windows builds. - Deprecation Warning Fix: Resolved a deprecation warning in the CI build process related to the GoReleaser configuration, ensuring compatibility with future GoReleaser versions.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates the GoReleaser configuration (.goreleaser.yml
) to address a deprecation warning for archives.format_overrides.format
. The change correctly replaces the deprecated format: zip
with formats: [zip]
for Windows builds, aligning with the official GoReleaser documentation. This proactive fix ensures continued compatibility and cleaner build logs by adhering to the current GoReleaser schema. The changes also follow standard YAML formatting conventions. No issues of medium or higher severity were identified within the scope of the provided diff.
Thanks! |
PR Summary
This small PR updates the GoReleaser configuration to resolve the following warnings which you can find in the CI logs: