Skip to content

fix: update GoReleaser configurations #4234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 15, 2025

Conversation

emmanuel-ferdman
Copy link
Contributor

PR Summary

This small PR updates the GoReleaser configuration to resolve the following warnings which you can find in the CI logs:

DEPRECATED: archives.format_overrides.format should not be used anymore, check https://goreleaser.com/deprecations#archivesformat_overridesformat for more info

Signed-off-by: Emmanuel Ferdman <emmanuelferdman@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @emmanuel-ferdman, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a deprecation warning in the GoReleaser configuration by updating the syntax for specifying archive formats for Windows builds. The change is minimal but necessary to maintain compatibility and silence build warnings.

Highlights

  • Configuration Update: Updated the GoReleaser configuration file (release/goreleaser.yml) to use the new formats key instead of the deprecated format key within the archives.format_overrides section for Windows builds.
  • Deprecation Warning Fix: Resolved a deprecation warning in the CI build process related to the GoReleaser configuration, ensuring compatibility with future GoReleaser versions.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the GoReleaser configuration (.goreleaser.yml) to address a deprecation warning for archives.format_overrides.format. The change correctly replaces the deprecated format: zip with formats: [zip] for Windows builds, aligning with the official GoReleaser documentation. This proactive fix ensures continued compatibility and cleaner build logs by adhering to the current GoReleaser schema. The changes also follow standard YAML formatting conventions. No issues of medium or higher severity were identified within the scope of the provided diff.

@deluan
Copy link
Member

deluan commented Jun 15, 2025

Thanks!

@deluan deluan merged commit 873905b into navidrome:master Jun 15, 2025
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants