Add EnableNowPlaying configuration #4219
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @deluan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request adds a new server configuration option, EnableNowPlaying, which provides control over whether the "Now Playing" panel is displayed in the user interface. The setting is exposed to the UI and included in insights data, allowing administrators to easily disable this feature if desired. The UI rendering logic has been updated to respect this new setting, and corresponding tests have been added.
Highlights
- New Configuration Option: Introduced
EnableNowPlayingboolean configuration option with a default value oftrueto control the visibility of the "Now Playing" panel. - UI Integration: The new
enableNowPlayingsetting is now injected into the UI configuration, allowing the frontend to react to the server setting. - Metrics and Insights: The
EnableNowPlayingsetting is included in the collected insights metrics data. - Frontend Logic: The
AppBarcomponent in the UI now conditionally renders theNowPlayingPanelbased on theenableNowPlayingconfiguration value, in addition to the existingdevActivityPanelandadminpermissions checks. - Testing: Added new tests for the server-side UI config injection and a dedicated test file (
AppBar.test.jsx) to verify the frontend rendering logic based on the new configuration.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configureGemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Signed-off-by: Deluan <deluan@navidrome.org>
Summary
EnableNowPlayingconfig option with default trueEnableNowPlayingis true, returning HTTP 501 otherwiseTesting
npm run lintnpm run check-formattingnpm run testnpm run type-checkmake testhttps://chatgpt.com/codex/tasks/task_b_684ae2b85c98832e93dfd5e40aef4cfc