Hello @deluan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request to help everyone get up to speed quickly.

This PR addresses a bug where artist images (artist.jpg, etc.) located directly in the artist's main folder were not being detected for artists with only a single album. The original implementation of fromArtistFolder only searched the calculated artist folder, which in the single-album case might not have been the correct location relative to the image file.

The solution implemented here enhances the fromArtistFolder logic to perform a directory traversal fallback. It now searches for the specified artist image pattern not just in the initial folder, but also in its parent and grandparent directories (up to 3 levels total). This ensures that images placed higher up in the directory structure, common in single-album artist layouts, are correctly found. The search prioritizes images found in directories closer to the initial folder.

Highlights

• Bug Fix: Fixes the specific issue where artist images in the artist folder were not detected for artists with only one album.
• Directory Traversal Fallback: The fromArtistFolder function now searches up to 3 directory levels (initial folder + 2 parents) to find artist images.
• Search Prioritization: Images found in directories closer to the initial artist folder are prioritized over those found further up the tree.
• Code Refactoring: The logic for searching within a single folder has been extracted into a new helper function, findImageInFolder, improving code organization.
• Comprehensive Testing: A new, extensive test suite with 10 scenarios has been added to cover various traversal depths, priority rules, edge cases (like filesystem boundaries and file errors), and specifically the original single-album artist issue.

Changelog

• core/artwork/reader_artist.go
  • Refactored fromArtistFolder (lines 109-134 -> 109-124) to implement a loop for directory traversal, searching up to 3 levels.
  • Introduced a new helper function findImageInFolder (lines 127-149) which contains the core logic for globbing and opening an image file within a single specified directory.
  • fromArtistFolder now calls findImageInFolder iteratively for the current directory and its parents.
  • Added boundary checks (current != string(filepath.Separator)) to prevent infinite traversal.
  • Improved error handling within the search loop to continue searching even if opening a specific file fails.
• core/artwork/reader_artist_test.go
  • Added necessary imports for io and os (lines 6-7).
  • Added a new Describe block specifically for testing the fromArtistFolder function (lines 114-383).
  • Included 10 distinct test scenarios covering successful finds at different depths, priority checks, multiple matches, no matches, filesystem root boundary, file access errors, glob patterns, and a specific test for the original single-album artist bug.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

A folder deep, an image sought,
Up the tree, a path is wrought.
Three steps high, the search will go,
To find the art, and make it show.

Code Review

This is a well-thought-out pull request that effectively addresses the bug with artist image detection for single-album artists. The introduction of directory traversal is a sensible solution, and the code changes are clear and well-structured. The extraction of findImageInFolder greatly improves readability. The accompanying tests are comprehensive and cover a wide range of scenarios, which is excellent.

I have a few suggestions for minor improvements, mostly around maintainability and test completeness. Overall, great work on this fix!

Summary of Findings

• Hardcoded Traversal Depth: The directory traversal depth in fromArtistFolder is hardcoded (line 112 of core/artwork/reader_artist.go). Using a named constant would improve readability and maintainability.
• Error Message Clarity: The error message in fromArtistFolder when no image is found (line 123 of core/artwork/reader_artist.go) could be more informative by mentioning that parent directories were also searched.
• Test Completeness for Unreadable Files: The test case for handling unreadable files (core/artwork/reader_artist_test.go, lines 315-325) doesn't fully validate the 'continues searching' behavior if the first matched file in a directory is unreadable and a subsequent one is readable. Enhancing this test would provide greater confidence in this specific error handling path.

Merge Readiness

The pull request is in good shape and addresses an important bug. The implemented solution is robust and the tests are generally comprehensive. There are a few medium-severity suggestions related to maintainability and test completeness that I recommend addressing or discussing before merging. As I am an AI assistant, I am not authorized to approve pull requests; please ensure other reviewers approve these changes before merging.

Pull Request Overview

Enhances the fromArtistFolder logic to search parent directories (up to two levels) when no artist image is found in the initial folder, fixing cases where single‐album artists’ images were missed.

• Introduce maxArtistFolderTraversalDepth and loop up to parent/grandparent directories
• Extract findImageInFolder helper for single‐directory searches with error handling and logging
• Expand tests to cover traversal depth, pattern matching, error cases, and the original single‐album bug

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

log.Warn(ctx, "Could not open cover art file", "file", filePath, err)

if err != nil {
    Expect(err.Error()).To(ContainSubstring("no matches"))
} else {
    Expect(reader).ToNot(BeNil())
    reader.Close()
}