Hello @deluan, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

Summary of Changes

Hello! Gemini here, providing a summary of this pull request. This PR introduces a new feature allowing users to delete all missing files from the database at once, in addition to the existing functionality for deleting selected missing files. This involves changes across the backend API, the data provider layer, the frontend UI components, and adds corresponding tests.

Highlights

• Backend API Enhancement: The native API endpoint for deleting missing files (DELETE /missing) is updated to handle requests without specific IDs. If no IDs are provided in the request parameters, the backend will now trigger a mass deletion of all files marked as missing.
• Frontend Data Provider Update: The wrapperDataProvider is modified to correctly handle DELETE_MANY calls for the 'missing' resource when the list of IDs is empty. It now constructs the request URL without the ?id=... query string in this specific case, aligning with the backend change.
• UI Component Flexibility: The DeleteMissingFilesButton component is enhanced with a new deleteAll prop. When this prop is set to true, the button's label and the confirmation dialog's title and content are updated to reflect the 'Remove All' action, and it triggers the delete operation with an empty list of IDs.
• New 'Remove All' Button: A new MissingListActions component is introduced and added to the MissingFilesList. This component includes an 'Export' button and the new DeleteMissingFilesButton configured with the deleteAll prop, providing a dedicated button in the UI to initiate the mass deletion.
• Translations Added: New translation keys (remove_all, remove_all_missing_title, remove_all_missing_content) are added to the English translation file (en.json) to support the text for the new 'Remove All' button and its confirmation dialog.
• Comprehensive Testing: New tests are added for both the backend repository (persistence/mediafile_repository_test.go) to verify the DeleteAllMissing function and for the frontend component (ui/src/missing/DeleteMissingFilesButton.test.jsx) to ensure the deleteAll prop behaves as expected, including using the correct label and calling the data provider with an empty ID list.

Changelog

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Files gone astray,
Marked missing, day by day.
One button press, poof!
Database gets its proof,
Clean slate, a brand new way.

Pull Request Overview

This PR adds the ability to remove all missing files at once through both the native API and frontend components. Key changes include:

• New remove-all functionality implemented in the native API and integrated in the DeleteMissingFilesButton component.
• Updates to the data provider to omit query strings on DELETE requests when no IDs are provided.
• Addition of a dedicated action button and corresponding translations for the remove-all feature.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Code Review

This pull request successfully adds the functionality to remove all missing files from the database via the native API and the UI. The changes are well-structured, covering the backend API, data provider, UI components, translations, and tests. The implementation correctly reuses existing components and patterns where appropriate.

Summary of Findings

• Backend Test Coverage: The new test for DeleteAllMissing (persistence/mediafile_repository_test.go) correctly verifies that missing files are deleted. A minor improvement could be to assert the exact count of missing files before calling DeleteAllMissing to ensure the test setup is correct and the >= 2 assertion is more precise. (Not commented on due to review settings)
• Frontend Component Readability: In ui/src/missing/DeleteMissingFilesButton.jsx, the use of ternary operators for selecting labels and confirmation messages based on the deleteAll prop is functional. For future maintainability, especially if more conditional text were added, using a helper function or an object lookup could make the code slightly cleaner. (Not commented on due to review settings)
• Frontend Test Coverage: The new tests in ui/src/missing/DeleteMissingFilesButton.test.jsx adequately cover the new behavior introduced by the deleteAll prop, ensuring the correct label is displayed and the useDeleteMany hook is called with an empty array. (Not commented on due to review settings)
• Translation Updates: New translation keys for the 'Remove All' action and confirmation messages have been added correctly in ui/src/i18n/en.json. (Not commented on due to review settings)
• Data Provider Logic: The modification in ui/src/dataProvider/wrapperDataProvider.js to handle empty ID lists for DELETE requests correctly aligns the frontend behavior with the new backend API endpoint logic. (Not commented on due to review settings)
• Backend API Logic: The update to the deleteMissingFiles handler in server/nativeapi/missing.go correctly routes requests with no IDs to the new DeleteAllMissing repository method, while preserving the existing behavior for deleting specific IDs. The use of ds.WithTx and the permission checks within the repository methods are appropriate. (Not commented on due to review settings)

Merge Readiness

The code changes appear correct and well-tested for the new functionality. Based on my review, there are no critical or high severity issues that would block merging. The pull request seems ready to be merged, but please note that I am unable to directly approve it. Other reviewers should review and approve this code before merging.