Handle missing artists for regular users #4092
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…anagement Signed-off-by: Deluan <deluan@navidrome.org>
3 tasks
There was a problem hiding this comment.
Caution
Changes requested ❌
Reviewed everything up to 7eae053 in 1 minute and 56 seconds. Click for details.
- Reviewed
302lines of code in7files - Skipped
0files when reviewing. - Skipped posting
4draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. model/artist.go:35
- Draft comment:
Ensure you update migration and docs for the new ‘Missing’ field in Artist. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%This comment is asking the author to ensure that migrations and documentation are updated for a new field. It is not a specific code suggestion or a request for a test, and it doesn't point out a specific issue with the code. It falls under the rule of not asking the author to ensure something is done.
2. persistence/artist_repository.go:113
- Draft comment:
Consider defining the table name 'artist' as a constant (per consts.go) instead of hardcoding. - Reason this comment was not posted:
Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. server/subsonic/browsing.go:43
- Draft comment:
Log errors with structured key–value pairs; consider passing the error with a key (e.g. 'error', err). - Reason this comment was not posted:
Comment was on unchanged code.
4. ui/src/dataProvider/wrapperDataProvider.js:27
- Draft comment:
Ensure the 'missing' filter is consistently applied on resources (e.g. 'artist') for non-admin users. - Reason this comment was not posted:
Confidence changes required:50%<= threshold50%None
Workflow ID: wflow_XQi6df9BgL8pTkbk
You can customize 
3 tasks
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a missing flag on the Artist model and uses it to:
- Automatically mark artists with only missing albums during GC.
- Exclude missing artists by default in both the Subsonic API and UI data layer for regular users.
- Visually dim missing artists in the artist list UI.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| ui/src/dataProvider/wrapperDataProvider.js | Add missing=false filter for non-admin users on artist fetches |
| ui/src/artist/ArtistList.jsx | Dim rows for missing artists with an opacity style |
| server/subsonic/browsing.go | Pass includeMissing=false to GetIndex in Subsonic browsing |
| persistence/persistence.go | Insert a GC step to run markMissing on artists |
| persistence/artist_repository.go | Add missing filter in GetIndex and implement markMissing |
| persistence/artist_repository_test.go | New tests for missing-artist visibility for regular vs. admin |
| model/artist.go | Add Missing field and update GetIndex signature |
Comments suppressed due to low confidence (2)
persistence/artist_repository.go:257
- [nitpick] The variable
cfor the row count returned byexecuteSQLis ambiguous. Consider renaming it torowsAffectedfor clearer intent.
c, err := r.executeSQL(q)
persistence/artist_repository.go:249
- [nitpick] The SQL string passed to
Expris indented, preserving leading spaces in the query text. For readability and to avoid embedding unnecessary whitespace, consider left-aligning or trimming the SQL.
q := Expr(`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
missingfield to artist modelTesting
make test