Skip to content

Fix memory leak in cache warmer #4095

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 22, 2025
Merged

Fix memory leak in cache warmer #4095

merged 3 commits into from
May 22, 2025

Conversation

deluan
Copy link
Member

@deluan deluan commented May 21, 2025

Summary

  • stop cache warmer when the file cache is disabled
  • expose Disabled method on FileCache
  • avoid buffering artwork when cache can't run
  • test cache warmer disabled behaviour
  • test FileCache.Disabled

Testing

  • make test

@github-actions GitHub Actions
Copy link

github-actions bot commented May 21, 2025 •
edited
Loading

Download the artifacts for this pull request:

@deluan deluan marked this pull request as ready for review May 22, 2025 01:35
deluan and others added 3 commits May 21, 2025 21:35
@deluan deluan force-pushed the hceq3c-codex/investigate-memory-leak-in-scanner-process branch from 19f6830 to d001dcb Compare May 22, 2025 01:35
@deluan deluan merged commit 6731787 into master May 22, 2025
35 checks passed
@deluan deluan deleted the hceq3c-codex/investigate-memory-leak-in-scanner-process branch May 22, 2025 01:48
@BrewTestBot BrewTestBot mentioned this pull request May 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
codex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deluan