Add ISRC support for OpenSubsonic Child #4088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Deluan <deluan@navidrome.org>
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 72a71eb in 28 seconds. Click for details.
- Reviewed
136lines of code in10files - Skipped
1files when reviewing. - Skipped posting
3draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. server/subsonic/helpers.go:227
- Draft comment:
Good: The new ISRC field is straightforwardly added via mf.Tags.Values(model.TagISRC). Ensure that mf.Tags.Values returns an empty slice when no ISRC exists. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
2. model/tag.go:194
- Draft comment:
Nice: The addition of the TagISRC constant ensures consistent reference to the ISRC tag. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
3. server/subsonic/responses/responses.go:178
- Draft comment:
The OpenSubsonicChild struct now includes the new Isrc field as Array[string]. This is consistent with JSON/XML expectations in snapshots. - Reason this comment was not posted:
Confidence changes required:0%<= threshold50%None
Workflow ID: wflow_eQhitZ5TN5Zzlveg
You can customize 
Signed-off-by: Deluan <deluan@navidrome.org>
There was a problem hiding this comment.
Skipped PR review on 33c0def because no changed files had a supported extension. If you think this was in error, please contact us and we'll fix it right away.
47 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
isrcfield on OpenSubsonicChild: [API Request] Return ISRC with song info opensubsonic/open-subsonic-api#123isrcvalues when building responses fromMediaFilemodel.TagISRCconstantTesting
make test