add artist/albumartist filter to media file #4001
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Important
Looks good to me! 👍
Reviewed everything up to 3409b2e in 2 minutes and 10 seconds. Click for details.
- Reviewed
12lines of code in1files - Skipped
0files when reviewing. - Skipped posting
2draft comments. View those below. - Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. persistence/mediafile_repository.go:95
- Draft comment:
Ensure that 'artistFilter' is implemented consistently and handles cases similar to other string filters. Consider adding unit tests for this new filter. - Reason this comment was not posted:
Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 10% vs. threshold = 50% The comment violates several rules: 1) It starts with "Ensure that..." which is explicitly discouraged 2) It's speculative without evidence of actual issues 3) It suggests adding tests which is not directly related to the code change 4) Without seeing the artistFilter implementation, we can't verify if there are actual consistency issues. Maybe there are actual inconsistencies in the artistFilter implementation that would make this comment valuable. The suggestion for tests could prevent future issues. Without seeing the artistFilter implementation, we can't verify any inconsistencies. The comment is speculative and uses "ensure that" phrasing which violates our rules. Delete this comment as it is speculative, uses discouraged phrasing, and makes suggestions without evidence of actual issues.
2. persistence/mediafile_repository.go:95
- Draft comment:
The PR title mentions adding both artist and albumartist filters, but only the 'artist' filter is added. Confirm if an albumartist filter is also needed or if the artistFilter covers both cases. - Reason this comment was not posted:
Comment did not seem useful. Confidence is useful =0%<= threshold50%The comment is asking the PR author to confirm if an additional filter is needed based on the PR title. This is not a specific code suggestion or a request for a test, and it violates the rule against asking the author to confirm their intention.
Workflow ID: wflow_gbK7YV4QvqcQqBRH
You can customize 
…drome into add-artist-filter-to-songs
deluan
approved these changes
Apr 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.