fix(scanner): fix misleading custom tag split config message.

deluan · deluan · commit be83d68956f0 · 2025-07-25T17:54:51.000-04:00
See #3901 (reply in thread) Signed-off-by: Deluan <deluan@navidrome.org>
diff --git a/model/tag_mappings.go b/model/tag_mappings.go
@@ -138,7 +138,7 @@ func compileSplitRegex(tagName TagName, split []string) *regexp.Regexp {
 		escaped = append(escaped, regexp.QuoteMeta(s))
 	}
 	// If no valid separators remain, return the original value.
-	if len(escaped) == 0 {
+	if len(split) > 0 && len(escaped) == 0 {
 		log.Warn("No valid separators found in split list", "split", split, "tag", tagName)
 		return nil
 	}
@@ -147,7 +147,7 @@ func compileSplitRegex(tagName TagName, split []string) *regexp.Regexp {
 	pattern := "(?i)(" + strings.Join(escaped, "|") + ")"
 	re, err := regexp.Compile(pattern)
 	if err != nil {
-		log.Error("Error compiling regexp", "pattern", pattern, "tag", tagName, "err", err)
+		log.Warn("Error compiling regexp for split list", "pattern", pattern, "tag", tagName, "split", split, err)
 		return nil
 	}
 	return re

Original file line number	Diff line number	Diff line change
`@@ -138,7 +138,7 @@ func compileSplitRegex(tagName TagName, split []string) *regexp.Regexp {`
`138`	`138`	`escaped = append(escaped, regexp.QuoteMeta(s))`
`139`	`139`	`}`
`140`	`140`	`// If no valid separators remain, return the original value.`
`141`		`- if len(escaped) == 0 {`
	`141`	`+ if len(split) > 0 && len(escaped) == 0 {`
`142`	`142`	`log.Warn("No valid separators found in split list", "split", split, "tag", tagName)`
`143`	`143`	`return nil`
`144`	`144`	`}`
`@@ -147,7 +147,7 @@ func compileSplitRegex(tagName TagName, split []string) *regexp.Regexp {`
`147`	`147`	`pattern := "(?i)(" + strings.Join(escaped, "\|") + ")"`
`148`	`148`	`re, err := regexp.Compile(pattern)`
`149`	`149`	`if err != nil {`
`150`		`- log.Error("Error compiling regexp", "pattern", pattern, "tag", tagName, "err", err)`
	`150`	`+ log.Warn("Error compiling regexp for split list", "pattern", pattern, "tag", tagName, "split", split, err)`
`151`	`151`	`return nil`
`152`	`152`	`}`
`153`	`153`	`return re`