#38: Add an auto-incremental id to jobs #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josecelano
requested changes
Apr 27, 2022
josecelano
requested changes
May 10, 2022
There was a problem hiding this comment.
hi @yeraydavidrodriguez I've added a couple of comments. And tests for the JobId class are missing.
c2f48c3 to
8bd2da7
Compare
josecelano
approved these changes
May 13, 2022
8bd2da7 to
87c06b6
Compare
87c06b6 to
2f22e0a
Compare
|
@yeraydavidrodriguez Great Work :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will solve #38 : Add autoincremental id to jobs.
This new Job parameter, a number (although a wrapper is going to be created as part of the issue) will be included in the message, mandatorily.
When the first job of a queue is created, the id will be 0 (zero), incrementing for each new job in the queue.