Issue #123: Use Full SHA1 Commit Hashes #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04c9458 to
ff01187
Compare
MegaLinter status: ✅ SUCCESS
See errors details in artifact MegaLinter reports on CI Job page |
|
@da2ce7 in this case the dependency update is mixed up with the rest of the code in the same commit because it's a breaking change. The commit would not work if we only had a commit with the dependency update. |
@josecelano This is Correct. The minimal amount of changes to facilitate a dependency change should be included in the commit that changes the dependency. - Every commit should pass the CI. |
ff01187 to
ea85e15
Compare
|
@josecelano rebased. |
Bug external project: nautilus-cyberneering/library-consumer#22 Internal issue: #123 The bug was temporarily fixed by setting git config to: git config --global core.abbrev 7 We do not need it anymore becuase SimpleGit has force commit hash length to the maximum (40 chararters). So we only use full hashes.
ea85e15 to
ec1d939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug external project: nautilus-cyberneering/library-consumer#22
Internal issue: #123
The bug was temporarily fixed by setting git config to:
We do not need it anymore becuase SimpleGit has force commit hash length
to the maximum (40 chararters). So we only use full hashes.
fixes #119