Skip to content

Import code from POC repo #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 19 commits into from
Feb 8, 2022
Merged

Import code from POC repo #12

merged 19 commits into from
Feb 8, 2022

Conversation

josecelano
Copy link
Member

@josecelano josecelano commented Feb 4, 2022 •
edited
Loading

WIP. I have imported the code from the POC repo and the tests are green. I have the expected lining errors because we were not using MegaLinter on the other repo.

TODO:

  • Fix lint errors: yarn lint.
  • Fix megalinter errors.
  • Fix workflow errors.

@josecelano josecelano linked an issue Feb 4, 2022 that may be closed by this pull request
Import code from POC repo #11
Closed
@github-actions
Copy link

github-actions bot commented Feb 4, 2022 •
edited
Loading

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.07s
✅ COPYPASTE jscpd yes no 1.26s
✅ CREDENTIALS secretlint yes no 0.84s
✅ GIT git_diff yes no 0.01s
✅ JAVASCRIPT standard 1 0 0 1.39s
✅ JSON eslint-plugin-jsonc 7 0 0 0.95s
✅ JSON jsonlint 7 0 1.81s
✅ JSON prettier 7 0 0 1.28s
✅ JSON v8r 7 0 7.94s
✅ MARKDOWN markdownlint 2 0 0 0.36s
✅ MARKDOWN markdown-link-check 2 0 0.88s
✅ MARKDOWN markdown-table-formatter 2 0 0 0.39s
✅ SPELL cspell 49 0 2.76s
✅ SPELL misspell 49 0 0 0.18s
✅ TYPESCRIPT eslint 23 0 0 10.73s
✅ YAML prettier 7 0 0 1.78s
✅ YAML v8r 7 0 7.32s
✅ YAML yamllint 7 0 0.19s

See errors details in artifact MegaLinter reports on CI Job page

@josecelano josecelano marked this pull request as ready for review February 8, 2022 12:30
@josecelano josecelano force-pushed the issue-11-import-action-code branch from 00755fd to 8324b07 Compare February 8, 2022 12:37
@josecelano
Copy link
Member Author

hi @da2ce7 @yeraydavidrodriguez I've just finished importing the code from the other repo. I've also added megalinter and fixed all the errors. I've disabled the standard linter in megalinter. So are only using the eslint linter. The original template only uses one. I do not know any reason now to use both of them especially because I have to spend a lot of time to set up them up to avoid conflicts on rules. I'm going to merge without review because nothing important has changed from the original repo.

@josecelano josecelano merged commit cb3fb2d into main Feb 8, 2022
@josecelano josecelano deleted the issue-11-import-action-code branch February 8, 2022 12:41
josecelano added a commit that referenced this pull request Jun 7, 2022
@josecelano
Merge pull request #12 from josecelano/dependabot/github_actions/acti…
503dbbb 
…ons/setup-python-3.1.2

build(deps): bump actions/setup-python from 2.3.1 to 3.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Import code from POC repo
1 participant
@josecelano