Skip to content

Refactor extract Job class #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 22, 2022
Merged

Refactor extract Job class #60

merged 2 commits into from
Feb 22, 2022

Conversation

josecelano
Copy link
Member

No description provided.

@josecelano josecelano linked an issue Feb 21, 2022 that may be closed by this pull request
Refactor: extract Job class #56
Closed
@josecelano josecelano requested a review from da2ce7 February 21, 2022 14:07
@github-actions
Copy link

github-actions bot commented Feb 21, 2022 •
edited
Loading

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.11s
✅ COPYPASTE jscpd yes no 1.88s
✅ CREDENTIALS secretlint yes no 0.99s
✅ GIT git_diff yes no 0.01s
✅ JAVASCRIPT standard 1 0 0 1.53s
✅ JSON eslint-plugin-jsonc 7 0 0 1.03s
✅ JSON jsonlint 7 0 2.07s
✅ JSON prettier 7 0 0 1.36s
✅ JSON v8r 7 0 6.75s
✅ MARKDOWN markdownlint 2 0 0 0.37s
✅ MARKDOWN markdown-link-check 2 0 2.89s
✅ MARKDOWN markdown-table-formatter 2 0 0 0.31s
✅ SPELL cspell 79 0 3.98s
✅ SPELL misspell 79 0 0 0.11s
✅ TYPESCRIPT eslint 53 0 0 14.8s
✅ YAML prettier 7 0 0 1.63s
✅ YAML v8r 7 0 9.67s
✅ YAML yamllint 7 0 0.24s

See errors details in artifact MegaLinter reports on CI Job page

@josecelano
Copy link
Member Author

There are also a couple of extra tests for other classes.

@josecelano josecelano marked this pull request as ready for review February 22, 2022 09:59
@josecelano josecelano force-pushed the issue-56-extract-job-class branch from 19a1131 to aff5924 Compare February 22, 2022 10:01
@josecelano josecelano merged commit bb1f1ce into main Feb 22, 2022
@josecelano josecelano deleted the issue-56-extract-job-class branch February 22, 2022 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

@yeraydavidrodriguez yeraydavidrodriguez Awaiting requested review from yeraydavidrodriguez

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor: extract Job class
1 participant
@josecelano