Skip to content

Refactor Queue class #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Feb 16, 2022
Merged

Refactor Queue class #47

merged 17 commits into from
Feb 16, 2022

Conversation

josecelano
Copy link
Member

Issue: #44

@josecelano josecelano added the enhancement New feature or request label Feb 15, 2022
@josecelano josecelano linked an issue Feb 15, 2022 that may be closed by this pull request
Refactor Queue class #44
Closed
8 tasks
@github-actions
Copy link

github-actions bot commented Feb 15, 2022 •
edited
Loading

MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 4 0 0.09s
✅ COPYPASTE jscpd yes no 1.56s
✅ CREDENTIALS secretlint yes no 0.93s
✅ GIT git_diff yes no 0.01s
✅ JAVASCRIPT standard 1 0 0 1.5s
✅ JSON eslint-plugin-jsonc 7 0 0 1.01s
✅ JSON jsonlint 7 0 1.9s
✅ JSON prettier 7 0 0 1.21s
✅ JSON v8r 7 0 6.39s
✅ MARKDOWN markdownlint 2 0 0 0.35s
✅ MARKDOWN markdown-link-check 2 0 3.43s
✅ MARKDOWN markdown-table-formatter 2 0 0 0.28s
✅ SPELL cspell 75 0 3.61s
✅ SPELL misspell 75 0 0 0.17s
✅ TYPESCRIPT eslint 49 0 0 13.23s
✅ YAML prettier 7 0 0 1.39s
✅ YAML v8r 7 0 8.71s
✅ YAML yamllint 7 0 0.32s

See errors details in artifact MegaLinter reports on CI Job page

@josecelano josecelano force-pushed the issue-44-refactor-queue-class branch from dd82a4b to 2ab1cce Compare February 15, 2022 12:19
@josecelano josecelano force-pushed the issue-44-refactor-queue-class branch from bec22dc to c25728f Compare February 15, 2022 13:26
@josecelano josecelano force-pushed the issue-44-refactor-queue-class branch from 6a00596 to 37dab66 Compare February 15, 2022 17:11
@josecelano josecelano marked this pull request as ready for review February 15, 2022 17:28
@josecelano
Copy link
Member Author

josecelano commented Feb 15, 2022 •
edited
Loading

@yeraydavidrodriguez @da2ce7 it's finished. I only expect to add one extra minor refactor and add extra tests to Queue class for corner cases.

@josecelano josecelano marked this pull request as draft February 15, 2022 17:34
@josecelano josecelano marked this pull request as ready for review February 16, 2022 16:23
@josecelano josecelano merged commit 201fcc4 into main Feb 16, 2022
@josecelano josecelano deleted the issue-44-refactor-queue-class branch February 16, 2022 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@da2ce7 da2ce7 Awaiting requested review from da2ce7

@yeraydavidrodriguez yeraydavidrodriguez Awaiting requested review from yeraydavidrodriguez

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor Queue class
1 participant
@josecelano