Skip to content

Tests fail when GPG was installed with non-english languages #66

@yeraydavidrodriguez

Description

@yeraydavidrodriguez

There are two tests that may fail if the user has installed the GPG suite using a non-english language: "should allow to sign commits" and "should allow to overwrite commit signing key"

This occurs because of the way the test checks for correctness. In both cases, we expect to find this string in an output structure:

gpg: using RSA key ${signingKeyFingerprint}

However, this is generated by GPG, and depends on the language with which was installed. For instance, in spanish, this string would be:

gpg: usando RSA clave ${signingKeyFingerprint}

And the test would fail, as in other languages. At the moment of writing this, the checks are made on queue.tests.ts:195 and main.test.ts:224.

To fix this, we need to perform a language-independent comparison, maybe checking the existence of the words "gpg", "RSA" and the fingerprint in the same string.

Metadata

Metadata

Labels

bugSomething isn't working

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions