Change DefaultSubPendingMsgsLimit comment to reflect actual value #998
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nats.go
Outdated
| @@ -4446,7 +4446,7 @@ func (s *Subscription) ClearMaxPending() error { | |||
|
|
|||
| // Pending Limits | |||
| const ( | |||
| // DefaultSubPendingMsgsLimit will be 512k msgs. | |||
| // DefaultSubPendingMsgsLimit will be 524,288 msgs. | |||
There was a problem hiding this comment.
I guess I assumed using Kb as unit in a non-storage context was not common. Happy to change if you think otherwise.. but when I see a b I immediately associate storage rather than a discrete number.
There was a problem hiding this comment.
Or we change it to 500_000
There was a problem hiding this comment.
Added another commit.. like so?
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just for consistency.. I don't seeing it help with understanding per se, but it could help in the edge case situation where the pending number is being reported and its greater than 512k which could be confusing.