Skip to content

[FIXED] Fix subject transform comparison #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 24, 2025

Conversation

erikmansson
Copy link
Contributor

When creating or updating a stream, the sources in the server response will not be ordered, but the current code assumes so. The commit removes that assumption.

Fixes #1906

When creating or updating a stream, the sources in the server response
will not be ordered, but the current code assumes so. The commit
removes that assumption.

Fixes #1906
@coveralls
Copy link

Coverage Status

coverage: 84.697% (-0.1%) from 84.837%
when pulling 2caa009 on erikmansson:fix-subject-transform-check-pr
into ea3ef92 on nats-io:main.

Copy link
Collaborator

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you for the contribution

@piotrpio piotrpio merged commit 0fc96b1 into nats-io:main Jul 24, 2025
4 checks passed
@piotrpio piotrpio mentioned this pull request Jul 29, 2025
@erikmansson erikmansson deleted the fix-subject-transform-check-pr branch July 30, 2025 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly incorrect check of source subject transforms
3 participants