[ADDED] Error() method to KeyLister and KeyWatcher interfaces #1889
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rfaces The new Error() method returns <-chan error, enabling concurrent error handling with select statements. This allows immediate detection of timeout errors during key listing/watching operations. Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
There was a problem hiding this comment.
Pull Request Overview
Adds an Error() channel to the legacy KV interfaces so callers can detect timeouts when waiting for initial values.
- Extended
KeyWatcherandKeyListerinterfaces with anError()method. - Implemented
errChin thewatcherandkeyListerstructs, sendingErrKeyWatcherTimeouton timeout and closing the channel on completion. - Added tests to validate channel-based error handling in both watch and list use cases.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| kv.go | Defined Error() on KeyWatcher/KeyLister, introduced errCh and timeout error handling. |
| test/kv_test.go | New test cases for select‐based and post‐completion error channel patterns. |
Comments suppressed due to low confidence (1)
test/kv_test.go:947
- [nitpick] This select loop has no timeout branch and could hang indefinitely if neither channel produces events. Add a
case <-time.After(...)to fail fast on missing signals.
select {
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added
Error()method to KeyLister and KeyWatcher in legacy KV API. This allows detection of timeout when waiting for initial values in watchers.Signed-off-by: Piotr Piotrowski piotr@synadia.com