[FIXED] Consumer.Next() hangs after connection is closed #1883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #1875 JetStream consumer operations would hang indefinitely after server shutdown or connection closure. Changes: - Fixed core NATS closed handler bug for ChanSubscription and SyncSubscription - Added ErrConnectionClosed error for better error context - Enhanced Consume() to report connection closure via ConsumeErrHandler - Improved Next() to wrap ErrMsgIteratorClosed with ErrConnectionClosed Both Messages().Next() and consumer.Consume() now properly handle connection closure and provide appropriate error reporting to applications. Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
ee6a59d to
0897f21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1875
JetStream consumer operations would hang indefinitely after server
shutdown or connection closure.
Changes:
Both Messages().Next() and consumer.Consume() now properly handle connection
closure and provide appropriate error reporting to applications.