Skip to content

Conversation

MauriceVanVeen
Copy link
Member

Counters already respected the server's MaxPayload, but did not yet respect the MaxMsgSize as configured on the stream. Also resolved cases where len(hdr)+len(msg) could potentially overflow.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner July 30, 2025 12:10
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/counter-maxmsgsize branch from fbebbed to fd73df6 Compare July 31, 2025 13:43
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen force-pushed the maurice/counter-maxmsgsize branch from fd73df6 to 3968b86 Compare July 31, 2025 13:49
Copy link
Member

@neilalexander neilalexander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit c010add into main Jul 31, 2025
69 of 70 checks passed
@neilalexander neilalexander deleted the maurice/counter-maxmsgsize branch July 31, 2025 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants