Skip to content

Conversation

dsidirop
Copy link
Contributor

No description provided.

dsidirop and others added 30 commits February 7, 2022 00:50
…() into kibibytes, mebibytes, kibibytes which are well-known, human-readable units of measurement
…able

  - the if-else structure was not really needed and it has been simplified to use plain 'ifs'
  - the "NA" case at the bottom would never be reached because all possible cases are already covered from a numerical perspective
…y-raw-bytes

ksidirop/NTOP 0053 flag to display raw bytes
…y-raw-bytes

clean (Psize unit tests): refactor the test harness to have it employ t.Run() instead of raw tests
…idirop/NTOP-0053-flag-to-display-raw-bytes
…y-raw-bytes

nats-io#53 new cli-flag '-b' to display raw bytes
  - consolidate 1024-related constants used in Psize() into kibibytes, mebibytes, kibibytes which are well-known, human-readable units of measurement
  - the if-else structure was not really needed and it has been simplified to use plain 'ifs'
  - the "NA" case at the bottom would never be reached because all possible cases are already covered from a numerical perspective
  - neutral cleanups in Psize() to make it more readable
  - refactor the test harness to have it employ t.Run() instead of raw tests
…tes-flag

ksidirop/NTOP 0053 support raw bytes flag
* 'main' of github.com:nats-io/nats-top:
  Add Raw bytes toggle (nats-io#55)
  nats-io#53 add -b flag to display traffic in raw bytes (nats-io#54)
…each redraw

  with this change we can support the new '-r N' flag to exit upon refreshing N times
…r of times nats-top should refresh nats-stats before exiting
…hing-N-times

Ksidirop/ntop 0052 support refreshing n times
…ave-single-snapshot-to-file

$57 new cli flag save single snapshot to file
…ave-single-snapshot-to-file

feat (cli flag '-o -'): passing '-o -' now prints the snapshot to the…
# Conflicts:
#	readme.md
#	util/toputils.go
…s to usage() with calls to fmt.Fprintf(os.stderr, ...)

   this fix allows the usage message to be actually printed (old was: log.Fatalf(...) would cause the program to os.exit(1) before
   the usage message could actually be printed)
dsidirop and others added 22 commits February 13, 2022 18:40
…mat-snapshot-csv

ksidirop/NTOP 59 new cli flag format snapshot csv
feat (--version): add support for printing version via the --version flag
…printed separated by whitespace chars instead of ',' because the ',' is frequently reserved to separate entire csv-columns in the resulting output
…play-subscriptions-column

ksidirop/NTOP 0069 new flag  display subscriptions column
…mn to not be delimiter-separator when the --display-subscriptions-column flag would be used in conjunction with -o
…idirop/NTOP-0069-new-flag--display-subscriptions-column

* 'master' of https://github.com/dsidirop/nats-top:
  clean (.gitignore)
…rop/NTOP-0069-new-flag--display-subscriptions-column

* 'main' of https://github.com/nats-io/nats-top:
  nats-io#69 new flag  --display-subscriptions-column (nats-io#70)
…ong option '--display-subscriptions-column' and updated the README.md file accordingly to mention these new options
@dsidirop
Copy link
Contributor Author

@wallyqs I opened this followup request to make some trivial updates to the README.md. Thanks in advance!

Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wallyqs wallyqs merged commit 2fce567 into nats-io:main May 26, 2022
dsidirop added a commit to dsidirop/nats-top that referenced this pull request Jun 4, 2022
* 'main' of https://github.com/nats-io/nats-top:
  nats-io#69 new flag  display subscriptions column - addendum for README.md (nats-io#71)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants