Skip to content

Conversation

dsidirop
Copy link
Contributor

@dsidirop dsidirop commented Feb 7, 2022

No description provided.

…() into kibibytes, mebibytes, kibibytes which are well-known, human-readable units of measurement
…able

  - the if-else structure was not really needed and it has been simplified to use plain 'ifs'
  - the "NA" case at the bottom would never be reached because all possible cases are already covered from a numerical perspective
…y-raw-bytes

ksidirop/NTOP 0053 flag to display raw bytes
…y-raw-bytes

clean (Psize unit tests): refactor the test harness to have it employ t.Run() instead of raw tests
…idirop/NTOP-0053-flag-to-display-raw-bytes
@dsidirop dsidirop changed the title Ksidirop/ntop 0053 flag to display raw bytes #53 add -b flag to display traffic in raw bytes Feb 7, 2022
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@wallyqs wallyqs merged commit da4bef5 into nats-io:master Feb 7, 2022
dsidirop pushed a commit to dsidirop/nats-top that referenced this pull request Feb 8, 2022
* 'main' of github.com:nats-io/nats-top:
  Add Raw bytes toggle (nats-io#55)
  nats-io#53 add -b flag to display traffic in raw bytes (nats-io#54)
dsidirop pushed a commit to dsidirop/nats-top that referenced this pull request Feb 8, 2022
…-top-extended

* 'main' of github.com:nats-io/nats-top:
  Add Raw bytes toggle (nats-io#55)
  nats-io#53 add -b flag to display traffic in raw bytes (nats-io#54)
@dsidirop dsidirop deleted the ksidirop/NTOP-0053-flag-to-display-raw-bytes branch February 8, 2022 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants