[ADD] DeliverBodies to disable headersOnly #546
Conversation
consumers.go
Outdated
| @@ -368,6 +368,14 @@ func DeliverHeadersOnly() ConsumerOption { | |||
| } | |||
| } | |||
|
|
|||
| // DeliverHeadersOnlyEx configures the consumer to deliver headers only. If headersOnly is false, the consumer will deliver the full message. | |||
| func DeliverHeadersOnlyEx(headersOnly bool) ConsumerOption { | |||
There was a problem hiding this comment.
Sorry I see now. This results in 2 ways to achieve the same.
So I think I would rather have a function something like DeliverBodies() or similar function rather than end up with 2 ways to set true
There was a problem hiding this comment.
Sorry, updated. I gave you the context in our Slack instead of here.
eec1fda to
e7b9d86
Compare
|
Seems you wanted to push a commit that moves to DeliverBodies() but github pr diff still shows the old names If not already done in the new code please update the comment on HeadersOnly indicating that the new function inverts it |
e7b9d86 to
bd1d572
Compare
Thank you. I edited the commit message and did not push the changes. |
|
Thank you! |
Add DeliverBodies, which allows a consumer to be updated with headersOnly: false
This change will also be helpful for Nack: https://github.com/nats-io/nack/blob/main/controllers/jetstream/consumer.go#L408-L410