Update dependencies.md #492
Conversation
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
dependencies.md
Outdated
| | github.com/antonmedv/expr v1.15.3 | MIT | | ||
| | github.com/dustin/go-humanize v1.0.1 | MIT | | ||
| | github.com/google/go-cmp/cmp v0.5.9 | BSD-3-Clause | | ||
| | github.com/klauspost/compress v1.17.0 | Apache-2.0 | |
There was a problem hiding this comment.
Do we really need versions here? This seems like a recipe for immediatley being out of date as we keep updating dependencies.
Also dont seem worth listing like compress and compress/s2?
There was a problem hiding this comment.
Here's an example from a previous cycle PR https://github.com/nats-io/natscli/pull/560/files
No versions, this seems extremely onerous if not strictly needed
There was a problem hiding this comment.
You're right, versions may be a bit much, I'll remove them.
The thing with compress is that compress/s2 actually has a different license file: https://github.com/klauspost/compress/blob/master/s2/LICENSE
There was a problem hiding this comment.
ah nice, missed the seperate license, good catch
There was a problem hiding this comment.
I removed the versions
Signed-off-by: Piotr Piotrowski <piotr@synadia.com>
| | github.com/antonmedv/expr | MIT | | ||
| | github.com/dustin/go-humanize | MIT | | ||
| | github.com/google/go-cmp/cmp | BSD-3-Clause | | ||
| | github.com/klauspost/compress | Apache-2.0 | |
There was a problem hiding this comment.
Actually this is wrong, looking at the repo he has a bunch of licences in the one file and the MIT one is first and applies to the main repo, I think it was right before @piotrpio
There was a problem hiding this comment.
Actually, I am not even sure what that license is, but its not ASL-2 or MIT
There was a problem hiding this comment.
It's BSD-3-Clause I guess, same as go
Signed-off-by: Piotr Piotrowski piotr@synadia.com