Skip to content

Use stderr for nsc invoke failed #405

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2022
Merged

Use stderr for nsc invoke failed #405

merged 1 commit into from
Aug 17, 2022

Conversation

bruth
Copy link
Member

@bruth bruth commented Aug 17, 2022

Use output since stderr is combined. The err value only states exit status 1 for the process exit code.

@bruth
Use stderr for nsc invoke failed
bdbf382 
Signed-off-by: Byron Ruth <b@devel.io>
@bruth bruth requested a review from ripienaar August 17, 2022 12:53
ripienaar
ripienaar approved these changes Aug 17, 2022
View reviewed changes
Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bruth bruth merged commit 4ff152d into main Aug 17, 2022
@bruth bruth deleted the nsc-invoke-failed-stderr branch August 17, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ripienaar ripienaar ripienaar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bruth @ripienaar