Skip to content

fix: header casing issues #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 25, 2020
Merged

fix: header casing issues #286

merged 3 commits into from
Jan 25, 2020

Conversation

atymic
Copy link
Contributor

@atymic atymic commented Jan 7, 2020 •
edited
Loading

See #285

This PR fixes the issue by allowing case insensitive header access as per the HTTP spec.

This is the broken test case for the bug. I'll write and PR the fix shortly here as well

@atymic
Copy link
Contributor Author

atymic commented Jan 12, 2020

ping @nategood

@nategood nategood merged commit 97a0389 into nategood:master Jan 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@atymic @nategood