Fix for frameworks that use object proxies #205
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm using the Typo3 Flow framework, that creates proxies for all classes. The proxy is created by extending the Request-class and overrides the constructor. It initializes the original Request-class by calling parent::__construct, but the private __construct method is not in scope. Instead the constructor should be marked as protected.
voku
added a commit
to voku/httpful
that referenced
this pull request
Apr 30, 2016
nategood
approved these changes
Dec 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using the Typo3 Flow framework, that creates proxies for all classes.
The proxy is created by extending the Request-class and overrides the constructor. It initializes the original Request-class by calling parent::__construct, but the private __construct method is not in scope. Instead the constructor should be marked as protected.