Solves issue #170: HTTP Header parsing is inconsistent #182
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Response\Headers lowercases header names.
Before header names were only lowercased when created by fromString.
| @@ -464,7 +464,7 @@ function testMultiHeaders() | |||
| $req = Request::init(); | |||
| $response = new Response(self::SAMPLE_JSON_RESPONSE, self::SAMPLE_MULTI_HEADER, $req); | |||
| $parse_headers = $response->_parseHeaders(self::SAMPLE_MULTI_HEADER); | |||
| $this->assertEquals('Value1,Value2', $parse_headers['X-My-Header']); | |||
| $this->assertEquals('Value1,Value2', $parse_headers['x-my-header']); | |||
There was a problem hiding this comment.
Hmm. This means that this will be a breaking change. Code that relied on the capitalization will break. Can we keep this backwards compatible and keep the capitalization?
There was a problem hiding this comment.
The culprit is the upstream implementation of Response\Headers::fromString. There the keys are stored lower case. I retained that behavior, and so had to change the test.
Should I drop the lower case?
|
How should I handle the lower case problem? |
|
Hi there. How should I handle the lower case problem? |
|
I removed the lower case code and reverted the test |
|
I just fixed all the issues. Headers remain as entered. |
voku
added a commit
to voku/httpful
that referenced
this pull request
Apr 30, 2016
|
Is there any intereset oin this pull request by upstream? |
|
Absolutely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This push request solves issue #170 by moving the code from Response::_parseCode to Response\Headers::fromString.